Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module name lookup not working in API #289

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

shbatm
Copy link
Contributor

@shbatm shbatm commented May 16, 2023

Bug Fix

Calling module name from the API would result in an error that the module name was not found.

Steps to reproduce

Attempt to use any of the example alert/showalert calls and they would fail, unless you changed to the module_0_alert in the URL.

Additional info

@shbatm shbatm changed the title Fix module name lookup not working Fix module name lookup not working in API May 16, 2023
@ezeholz
Copy link
Collaborator

ezeholz commented May 19, 2023

Hi! Glad to see you

Please change this merge to point into develop, I'll test it in a few days.

Edit: Oh, well. It's a small fix. Let me drop it out inside the correct branch, and I'll later in the week prepare a new version.

@ezeholz ezeholz changed the base branch from master to bug-fixes May 19, 2023 06:51
@shbatm shbatm changed the base branch from bug-fixes to develop May 19, 2023 09:51
@shbatm shbatm changed the base branch from develop to bug-fixes May 19, 2023 09:51
@ezeholz ezeholz merged commit d1346e0 into Jopyth:bug-fixes Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants