Bug correction (#76) and new functionnalities #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug correction for Brightness control : Jopyth#76 New functionnalities : - add a Notification to others modules names "USER_PRESENCE" to true or false when MONITORON or MONITOROFF are requested - possibility to send this Notification "USER_PRESENCE" to true or false by other module request (for example, I use MMM-Navigation to send USER_PRESENCE to true to allow my module update on request) This notification "USER_PRESENCE" can also be send by the module MMM-PIR-Sensor.
New functionnalities : - add a Notification to others modules names "USER_PRESENCE" to true or false when MONITORON or MONITOROFF are requested - possibility to send this Notification "USER_PRESENCE" to true or false by other module request (for example, I use MMM-Navigation to send USER_PRESENCE to true to allow my module update on request) This notification "USER_PRESENCE" can also be send by the module MMM-PIR-Sensor.
- Add examples to use Remote-control with MMM-Navigate - Update to take into account the add of "USER_PRESENCE" notification to other modules (modification proposed on the 2 other files) - Update to add example to use Brightness modification (after the correction of the issue Jopyth#76 proposed into node_helper.js file)
|
The USER_PRESENCE feature would be good to have in the "main" module as well. +1 for integrating it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This notification "USER_PRESENCE" can also be send by the module MMM-PIR-Sensor.
Tested some days on MM2 v2.4.1 on a RPI2