Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make figure prettyer #11

Merged
merged 2 commits into from
May 6, 2022
Merged

Make figure prettyer #11

merged 2 commits into from
May 6, 2022

Conversation

JoranAngevaare
Copy link
Owner

Make it nicer

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 6, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.56%.

Quality metrics Before After Change
Complexity 0.00 ⭐ 0.00 ⭐ 0.00
Method Length 161.50 😞 196.50 😞 35.00 👎
Working memory 20.00 ⛔ 22.00 ⛔ 2.00 👎
Quality 40.47% 😞 37.91% 😞 -2.56% 👎
Other metrics Before After Change
Lines 78 86 8
Changed files Quality Before Quality After Quality Change
thesis_plots/rotation_curve/rotation_curve_milkyway.py 40.47% 😞 37.91% 😞 -2.56% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
thesis_plots/rotation_curve/rotation_curve_milkyway.py combined_milkiway_plot 0 ⭐ 385 ⛔ 22 ⛔ 37.91% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@coveralls
Copy link

coveralls commented May 6, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling b66e67d on tweak-plots into 37afa4d on master.

@JoranAngevaare JoranAngevaare merged commit 7a13144 into master May 6, 2022
@JoranAngevaare JoranAngevaare deleted the tweak-plots branch May 6, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants