Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add galaxy plot #7

Merged
merged 18 commits into from
May 5, 2022
Merged

Add galaxy plot #7

merged 18 commits into from
May 5, 2022

Conversation

JoranAngevaare
Copy link
Owner

Add a galaxy plot

@coveralls
Copy link

coveralls commented May 4, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling 6349bfd on rot_curves_milkyway into 76068ad on master.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 5, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.89%.

Quality metrics Before After Change
Complexity 0.95 ⭐ 0.91 ⭐ -0.04 👍
Method Length 49.56 ⭐ 48.00 ⭐ -1.56 👍
Working memory 7.11 🙂 6.91 🙂 -0.20 👍
Quality 74.22% 🙂 75.11% 0.89% 👍
Other metrics Before After Change
Lines 155 163 8
Changed files Quality Before Quality After Quality Change
setup.py 65.78% 🙂 65.19% 🙂 -0.59% 👎
tests/test_basics.py 100.00% ⭐ 100.00% ⭐ 0.00%
tests/test_rotation_curve.py 97.67% ⭐ 98.39% ⭐ 0.72% 👍
thesis_plots/main.py 98.50% ⭐ 98.50% ⭐ 0.00%
thesis_plots/rotation_curve/init.py % % %
thesis_plots/rotation_curve/rotation_curve.py 71.03% 🙂 71.03% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
thesis_plots/rotation_curve/rotation_curve.py RotationCurve.__init__ 3 ⭐ 236 ⛔ 7 🙂 59.66% 🙂 Try splitting into smaller methods
thesis_plots/rotation_curve/rotation_curve.py RotationCurve.plot_rotation_curve_fancy 1 ⭐ 182 😞 7 🙂 65.47% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@JoranAngevaare JoranAngevaare merged commit e21a254 into master May 5, 2022
@JoranAngevaare JoranAngevaare deleted the rot_curves_milkyway branch May 5, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants