Migrate to null safety

[nilsreichardt]

Description

All dependencies are migrated to null safety. So we should migrate this package to null safety.

Resources

• How to migrate Dart packages to null safety
• Announcing Dart null safety beta

[6h4n3m]

I do not think the package is maintained anymore.

I've forked and migrated the package myself since I'm using it in one of my projects, you can depend on my fork like this:

liquid_progress_indicator:
    git: https://github.com/6h4n3m/liquid_progress_indicator.git

Some changes will be required to your app/package because some parameters are now required but were not before, but it's as easy as providing some colors/widths...etc.

Edit: To clarify, I'm not planning on making any changes or maintaining the library, you're welcome to fork my own fork and use that in your production code if you're afraid any changes will be introduced into master, or you can even depend on a specific ref.

[JErazo7]

I do not think the package is maintained anymore.

I've forked and migrated the package myself since I'm using it in one of my projects, you can depend on my fork like this:

liquid_progress_indicator:
    git: https://github.com/6h4n3m/liquid_progress_indicator.git

Some changes will be required to your app/package because some parameters are now required but were not before, but it's as easy as providing some colors/widths...etc.

Edit: To clarify, I'm not planning on making any changes or maintaining the library, you're welcome to fork my own fork and use that in your production code if you're afraid any changes will be introduced into master, or you can even depend on a specific ref.

Can you upload as a new package in pub.dev?

[6h4n3m]

I do not think the package is maintained anymore.
I've forked and migrated the package myself since I'm using it in one of my projects, you can depend on my fork like this:

liquid_progress_indicator:
    git: https://github.com/6h4n3m/liquid_progress_indicator.git

Some changes will be required to your app/package because some parameters are now required but were not before, but it's as easy as providing some colors/widths...etc.
Edit: To clarify, I'm not planning on making any changes or maintaining the library, you're welcome to fork my own fork and use that in your production code if you're afraid any changes will be introduced into master, or you can even depend on a specific ref.

Can you upload as a new package in pub.dev?

https://pub.dev/packages/liquid_progress_indicator_ns

[slavap]

@6h4n3m
You have made a mistake in your null safety porting: borderWidth and borderColor are required ONLY if one of them is defined, they could be both null (and it was always working like that). Please fix it. Check in non-null safety version was:

if (borderWidth != null && borderColor == null ||
        borderColor != null && borderWidth == null) {
      throw ArgumentError("borderWidth and borderColor should both be set.");
    }

[volgin]

@6h4n3m
You have made a mistake in your null safety porting: borderWidth and borderColor are required ONLY if one of them is defined, they could be both null (and it was always working like that). Please fix it. Check in non-null safety version was:

if (borderWidth != null && borderColor == null ||
        borderColor != null && borderWidth == null) {
      throw ArgumentError("borderWidth and borderColor should both be set.");
    }

This code is obviously wrong.

[slavap]

@volgin What do you mean wrong? It is code BEFORE null safety migration, after migration you have to specify both borderWidth and borderColor - which is wrong of course.

[volgin]

@slavap Missing parenthesis. It should be:

if ((borderWidth != null && borderColor == null) ||
        (borderColor != null && borderWidth == null)) {
      throw ArgumentError("borderWidth and borderColor should both be set.");
}

This code never did what it was supposed to do.

[slavap]

@volgin Why? At least in non-migrated to null safety version was no need to define explicitly both borderWidth and borderColor.

[volgin]

@slavap I understand what you are saying. But the code that you posted does NOT do what you think it does. Without extra parenthesis it makes no sense.

[slavap]

@volgin What parenthesis are you talking about? This code works and checks that both are null OR both are not null.

[JordanADavies]

Done. Sorry it's taken so long.