-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Research and explain Boolean type #139
Comments
Yeah... that's a good question 😅 Haha! I'm coming from a Java background and the
I think I like the 'Haskell Differences' idea better because it's the only language I know of that uppercases the Thoughts? |
You may simply want to link to this: |
@thomashoneyman True. I can't recall whether I'd already linked to that specific page or not (I'm guessing not). However, this particular issue can either be solved by updating that repo's page to include that True/False difference or we restate it here. Either way splits the content into two places. |
I don't think you linked to the differences, at least I can't remember either. I think we should update that repo's page + offer a short javascript influence explanation in this repo which would talk about why such a simple data type would need literal values instead of the regular constructors. |
Either way, we should link to that page. My question is, where should that link ideally appear? In the
Seems like there should be a |
I think the |
@razcore-art Would you be willing to submit a PR that includes a small snippet for Haskellers in the Syntax part that explains Boolean's quirk? I'll submit a separate PR that includes the link to the Differences from Haskell page, though if you want to include that in a PR, go for it. I was going to put it in its own section in the |
I can try and see what happens, you know you're giving this task to a total
beginner :). I can link with Purescript differences from Haskell as well.
…On Fri, Nov 16, 2018 at 10:18 PM JordanMartinez ***@***.***> wrote:
@razcore-art <https://github.com/razcore-art> Would you be willing to
submit a PR that includes a small snippet for Haskellers in the Syntax part
that explains Boolean's quirk? I'll submit a separate PR that includes the
link to the Differences from Haskell page, though if you want to include
that in a PR, go for it. I was going to put it in its own section in the Getting
Started/Other Imporant Info.md.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#139 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABH3pLMT5S1TbZW4bCEXv45CdE5HVD-Hks5uvx2ggaJpZM4YiJb->
.
|
And...? Haha! This whole repo is my understanding of PureScript, any and all of which could be wrong, haha! If you happen to contribute something that is wrong, you're in good company. We can learn together. Still, I don't think this particular issue is that difficult. You're basically saying, "In Haskell, you write
Ok, thanks! |
some notes on research: a bit of confusion, seems like I'm not the only one: purescript/purescript#842, especially this comment purescript/purescript#842 (comment) |
Mm... that makes a lot more sense. Rather than using |
|
Mind submitting a PR that changes that? |
I can take care of that sure. |
@razcore-art Thanks! And just to make sure this gets done instead of turning into |
Yes, that's acceptable :) |
I've linked to the documentation repo and also a PDF that I also found quite helpful and descriptive (see #156). What are the next actions for this issue? |
Your low maintenance work on this repo is far more active than I initially thought :). Yes, I just need to explain in writing why purescript |
Perhaps I should define "low maintenance": if it requires me to do additional work for a new release each time (e.g. something more than submit development PR on latestRelease branch, summarize new changes, define new tag and release on GH), then it's no longer low maintenance. If it's fixing bugs or adding new content, I just consider that learning.
Excellent! |
Well I didn't get to it that day :) but I'm getting to it right now |
Looks like nobody did mention The world doesn't seem to have blown up if I declare
And a |
Can you open an issue on the documentaiton repo? |
Context
Indicate the affected section (i.e. top-level folder)
I'm not sure where it would go
Indicate what kind of issue this is
Enhancement = a new idea that can be documented/filed
If it applies, indicate the file to which you are referring using non-numerical-ordering names
Body
As it stands, purescript has a
Boolean
type withtrue
&false
values. Beginners such as myself, especially ones coming from haskell where there's thedata Bool = True | False
definition, might wonder where'sTrue
&False
in purescript. Or why they're not present. I don't know the full history behind it but I assume it has to do with purescript being so tightly linked with javascript. It can definitely be a point of confusion as one would expect all constructors to start with a capital letters and this being such a simple data type one wouldn't expect literal values for it, or at least it's a bit of a discord compared to basic types.The text was updated successfully, but these errors were encountered: