Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make next major release: ps-0.13.x-v0.16.0 #344

Merged
merged 14 commits into from
Jun 12, 2019
Merged

Make next major release: ps-0.13.x-v0.16.0 #344

merged 14 commits into from
Jun 12, 2019

Conversation

JordanMartinez
Copy link
Owner

WIP

Fixes #343

@JordanMartinez JordanMartinez added the Release-PR Groups PRs that merged all commits from the development branch branch into latestRelease branch label Jun 4, 2019
@JordanMartinez
Copy link
Owner Author

So, Halogen v5 changed their API. A 'request' styled query now returns a Maybe a rather than just an a. I found that I could use AVars to "block" the business logic "thread" until the UI "thread" did what it was supposed to do. However, this seemed to be an example of an anti-pattern. So, I've decided to show a simple example of that antipattern using the ReaderT approach and then just move all the other code (including tests) outside of the src directory and into a deadcode directory. This prevents the code from being included in the compilation (which causes it to fail) but allows others to look at the code I wrote previously, how it worked, and why it failed.

I've done those changes and will be finishing up this PR most likely today if not tomorrow.

@JordanMartinez
Temporarily use my fork of purescript-benchotron
b9319d2
@JordanMartinez
Move 'dead code' into 'z-dead'; doc anti-pattern
47f8e25 
- Halogen v5 request-styled query (i.e. H.request) no longer returns . Now it returns  when one binds it via do notation.
- While my code will never allow the query to return a Nothing, I don't want to use 'unsafeCrashWith Impossible. either. So, I used an AVar to handle the control flow.
- The control flow became quickly unreasonable and I believe this example is more of an anti-pattern rather than something that should be followed. To make maintenance easier, I moved the 'dead code' to its own folder so others can still look at it, but know that it no longer compiles.
@JordanMartinez
Upgrade package sets for entire project to latest one
8607c1c
@JordanMartinez
Update optparse package to remove stack-overflow issue
ad0a1d5
@JordanMartinez
Update ToC file to upcoming ps-0.13.x-v0.16.0 release
e9515b3
@JordanMartinez
No longer run 'dead code' in CI
0120ebd
@JordanMartinez JordanMartinez merged commit e06ace9 into latestRelease Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Release-PR Groups PRs that merged all commits from the development branch branch into latestRelease branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update project to PureScript 0.13
1 participant
@JordanMartinez