Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #512

Merged
merged 1 commit into from
Sep 12, 2020
Merged

Conversation

goertzenator
Copy link
Contributor

Fix misc typos.

And thanks for writing this article; I couldn't find anything like it elsewhere.

fix misc typos
@JordanMartinez
Copy link
Owner

Thanks! I wrote it after bashing my ahead against Aff and Node.ReadLine.

Unfortunately, I'm doing some pretty big breaking changes in #511 (e.g. moving folders around). Could you wait until I finish doing that? (Might take two weeks at most). Once I'm done, this PR could target that branch.

@JordanMartinez
Copy link
Owner

@goertzenator Thanks for waiting. Would you mind doing this fix on top of latestRelease now? I did some pretty big file/folder shuffling in #511

@JordanMartinez
Copy link
Owner

Hm... Nevermind. Looks like there wasn't any merge conflicts. I just assumed there would be.

Thanks!

@JordanMartinez JordanMartinez merged commit 77cf29c into JordanMartinez:latestRelease Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants