Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No clear message that uploading child image is mandatory (may want to make it not mandatory) #188

Closed
ckelwin opened this issue Oct 8, 2023 · 1 comment
Assignees
Labels
🐛 bug Something isn't working bugfix-branch good first issue Good for newcomers hacktoberfest ⛏️ HacktoberFest contributions
Milestone

Comments

@ckelwin
Copy link
Collaborator

ckelwin commented Oct 8, 2023

Describe the bug
It appears to be mandatory to upload a child image (as cannot save child record without uploading one), but there is no warning/error message.

To Reproduce
Steps to reproduce the behavior:

  1. Login as parent.
  2. Click on the (+) button at the bottom right to add a child.
  3. In the Add child page:
  • Child name = A
  • Email = A
  • Press save, without upload an image by clicking the add picture button.
  1. Notice that nothing happens. No warning/message to indicate it's mandatory to add a picture.

Expected behavior
Either:

  1. Have a message to indicate it's mandatory to upload an image, or
  2. Make it not mandatory. And on the parent Dashboard, the child's image will be replaced with a 'default image'.
@JordyHers JordyHers added 🐛 bug Something isn't working good first issue Good for newcomers bugfix-branch hacktoberfest ⛏️ HacktoberFest contributions labels Oct 8, 2023
@JordyHers JordyHers added this to the v.2.0.0 milestone Oct 8, 2023
ckelwin added a commit to ckelwin/Times-up-flutter that referenced this issue Oct 12, 2023
…a new child. A default icon will be displayed as a substitute.
@ckelwin
Copy link
Collaborator Author

ckelwin commented Oct 12, 2023

Opened a PR and ready for review. Got the branch prefix wrong though but it's in my forked repo, so hope it's not a problem?

ckelwin added a commit to ckelwin/Times-up-flutter that referenced this issue Oct 21, 2023
…a new child. A default icon will be displayed as a substitute.
JordyHers added a commit that referenced this issue Oct 21, 2023
…-mandatory

fix(#188): Made child picture not mandatory when adding a new child
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working bugfix-branch good first issue Good for newcomers hacktoberfest ⛏️ HacktoberFest contributions
Projects
Archived in project
Development

No branches or pull requests

2 participants