Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable dark mode and light mode #24

Closed
JordyHers opened this issue May 30, 2023 · 7 comments
Closed

enable dark mode and light mode #24

JordyHers opened this issue May 30, 2023 · 7 comments
Assignees
Labels
hacktoberfest ⛏️ HacktoberFest contributions
Milestone

Comments

@JordyHers
Copy link
Contributor

JordyHers commented May 30, 2023

Current Behaviour:

The dark mode and light mode are not set up in the app.

Expected Behaviour:

The colors of the dark mode should be the opposite.
Scaffold background color should be darker.
white text should be dark etc...

On click the entire app mode should change smoothly You can

My approach 😁

(just a suggestion)

  • use ChangeProviderNotifier
  • create an abstract class that extends it.
  • use the methods inside like {set to dark mode}
  • call notifyListeners
  • wrap the entire App in a Consumer widget 🚀

Steps to Reproduce:

NO/

Environment:

Emulator: Pixel 6 Pro
Android version: 12
Android SDK: 33

@JordyHers JordyHers added this to the v.2.0.0 milestone Jun 1, 2023
@siddesh3101
Copy link
Contributor

can i do this with riverpod?

@JordyHers
Copy link
Contributor Author

JordyHers commented Jun 3, 2023

It's better to use just provider or changeNotifierProvider. This will avoid having different state management solutions in the project. There is already BLOC for sign-in 😁 @siddesh3101

@siddesh3101
Copy link
Contributor

ok i will try to do this with provider and in case i am stuck i will update the ticket to help needed

@JordyHers JordyHers added the hacktoberfest ⛏️ HacktoberFest contributions label Oct 1, 2023
@ckelwin
Copy link
Collaborator

ckelwin commented Oct 7, 2023

I will be working on this.

@JordyHers
Copy link
Contributor Author

@ckelwin Thank you man. Yes go for it. 😁

@ckelwin
Copy link
Collaborator

ckelwin commented Oct 8, 2023

@JordyHers ready for review. Did a quick sweep to just ensure things works for now. May need a bit more touch up. Only did it for the parent app as there's no option/settings to toggle this in the child app now. Maybe a separate issue for that?

JordyHers added a commit that referenced this issue Oct 8, 2023
@JordyHers
Copy link
Contributor Author

@ckelwin I will fix it up do not worry.

@ckelwin ckelwin self-assigned this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest ⛏️ HacktoberFest contributions
Projects
Archived in project
Development

No branches or pull requests

3 participants