Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/20 implement flavors #143

Merged
merged 11 commits into from
Jun 28, 2023
Merged

Chore/20 implement flavors #143

merged 11 commits into from
Jun 28, 2023

Conversation

JordyHers
Copy link
Contributor

BREAKING CHANGE ⚠️

Hi team,

I have reviewed the latest changes in the pull request, and I noticed that there have been significant updates to the app architecture by incorporating flavors. This is a major change that impacts various aspects of the application.

With the introduction of flavors, different flavors of the app can now be built, each with its own configuration and behavior. This allows us to customize the app for different environments, such as development, staging, and production.

However, please note that due to the implementation of flavors, the sign-in functionality has been affected, and currently, signing in is not available. The Firebase authentication system has been reimplemented as part of these changes. To get more detailed information about this modification and its implications, I recommend reaching out to the code owner responsible for these updates.

Overall, the addition of flavors brings flexibility and scalability to the app architecture, enabling easier configuration management across different environments. It's essential to ensure thorough testing and verification of the new changes to guarantee a smooth transition.

If you have any questions or need further clarification regarding these updates, please don't hesitate to ask the code owner or leave your comments here.

Thank you!

@JordyHers JordyHers requested a review from i-am-ijaz June 28, 2023 13:19
@i-am-ijaz
Copy link
Contributor

@JordyHers This is the Firebase project id time-tracker-flutter-5c61e?

@JordyHers
Copy link
Contributor Author

time-tracker-flutter-5c61e

Nope it is not. where did you get this id ? 🤷🏾‍♂️

@JordyHers JordyHers added the review Needs Review label Jun 28, 2023
@JordyHers JordyHers merged commit 64cbc7b into dev Jun 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants