fix(#55) : fixes a bug 'makers on the map sometimes disappear when en… #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tering the full screen' by handling the null and empty data of position as well as markers
|
@i-am-ijaz I will have a look |
|
@i-am-ijaz I have checked out your branch and the markers work perfectly on full screen mode. BUt they do not appear at all on the HomeScreen Map. Any idea why ? |
…toring the code and calling the setState as soon as markers init
…sappear-when-entering-full-screen-mode
JordyHers
approved these changes
Jun 7, 2023
JordyHers
added
ready-to-merge
and removed
question
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Fixes a bug 'makers on the map sometimes disappear when entering the full screen' by handling the null and empty data of position as well as markers