Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextArgument backed ListArgument #351

Closed
Minenash opened this issue Oct 21, 2022 · 2 comments
Closed

TextArgument backed ListArgument #351

Minenash opened this issue Oct 21, 2022 · 2 comments
Labels
enhancement New feature or request implemented for next release This has been implemented in the current dev build for the next public release

Comments

@Minenash
Copy link

Minenash commented Oct 21, 2022 •
edited

Description

Currently, the ListArgument uses GreedyStringArgument as the backbone, and while it has the advantage of not needing quotes for anything not alphanumeric_, it limits commands to a maximum of 1 list arguments.

It would be nice to also have a TextArgument backed version, that would allow multiple lists, with the cost of quotes, unless they use _ as the delimiter.

Expected code

The simplest would probably be changing the .build() to .buildGreedy() an .buildText(), with .build() being an alias to the greedy one to keep compatibility

Extra details

No response
@Minenash Minenash added the enhancement New feature or request label Oct 21, 2022
JorelAli added a commit that referenced this issue Oct 21, 2022
@JorelAli
Adds ListTextArgument for #351
a6ae026
JorelAli added a commit that referenced this issue Oct 21, 2022
@JorelAli
Adds ListTextArgument for #351 (#353)
0cc803f
@JorelAli
Copy link
Owner

Implemented for 8.6.0's release.

@JorelAli JorelAli added the implemented for next release This has been implemented in the current dev build for the next public release label Oct 21, 2022
@JorelAli JorelAli mentioned this issue Nov 23, 2022
Closed
@JorelAli
Copy link
Owner

JorelAli commented Dec 4, 2022

Implemented in release 8.6.0.

@JorelAli JorelAli closed this as completed Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request implemented for next release This has been implemented in the current dev build for the next public release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JorelAli @Minenash