-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure project for Velocity support #347
Merged
JorelAli
merged 323 commits into
JorelAli:dev/velocity-attempt-2
from
willkroboth:dev/platformSupport
Oct 6, 2022
Merged
Restructure project for Velocity support #347
JorelAli
merged 323 commits into
JorelAli:dev/velocity-attempt-2
from
willkroboth:dev/platformSupport
Oct 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in addition to strings)
…r command tree JSON files
… wrong name. Adds namespacedkey argument annotation. Start moving out auxiliary NMS classes
…core (except NMS)
…rializer to permit Paper servers to work properly.
Adds command trees example to main README
Allow suggestions and tooltips to be provided as collections in addition to arrays
* First implementation of Kotlin in the documentation for BooleanArguments * Improve kt example with lambdas for BooleanArgument * Adds ranged argument kotlin docs + unregister commands kotlin docs * Greedy, Location, Rotation, ChatColor argument examples in KotlinDocs * Work on KotlinDocs (1/3). Fix JorelAli#341 issue with mislinked documentation example * Work on KotlinDocs (2/3). Note notable issues with TODO in Examples.kt * Work on KotlinDocs examples (3/4) * Work on KotlinDocs examples (4/?) * Work on KotlinDocs examples (5/6) * Finish work on KotlinDocs examples (6/6) * Fix KotlinDocs example failing to compile * Remove trailing spaces and unnecessary brackets * Remove a TODO which has now been resolved
* First implementation of command visualizer as typescript (ignoring arguments) * Converts arguments.js -> arguments.ts * Fix string reader parsing issues with block pos args * Remove ts-errors. Prevent unused locals/parameters * Tidy up directory structure, with src/ for sources and dist/ for outputs * Update commandvisualizer readme with updated instructions * Adds potion effect argument. Fix issues with autocomplete * Adds AngleArgument and UUIDArgument * Work on implementing the entity selector argument * Make use of webpack-dev-server instead of http-server * Adds NBT to entity selector argument type. Adds gamemode, sort and limit * Adds better error message when NBT fails * Adds scores, template for suggestions tags and ranged bounds to entity selector argument * Add entity types, team and suggestions generator to entity selector argument * Work on suggestions for entity argument. Adds scrolling suggestions + hover event. Work on pinpointing cursor placement nonsense * Fix cursor placing bugs. Work on ensuring suggestions scroll into view. Fix suggestions autocomplete bugs. * Fix Firefox incompatibilities with command visualizer * Fix player limits and implement other entity selector arguments * Augment node-brigadier's StringReader with readLocationLiteral method * Move other StringReader extensions into brigadier_extensions * Enable strict null checks * Mess around with type predicates * Move valid box below command entry. Add mousedown event for suggestions to autocomplete * Fix webpack not recognising brigadier extensions * Adds math operation argument. Simplify argument implementations * Make a dedicated box for displaying errors * Adds Enchantment, NBT, IntRange, FloatRange and Function arguments * Implementation Function, ItemSlot, ResourceLocation, Rotation, ScoreboardSlot, Dimension arguments
…re to prepare for moving all classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restrucutres the commandapi platform to allow adding support for Velocity and other platforms. Most of the old code has been moved into the module
commandapi-platforms.commandapi-bukkit
, and thecommandapi-platforms.commandapi-velocity
module has been set up. The next steps to resolving #343 would be setting up a velocity plugin in thecommandapi-velocity
module and figuring out which code can be shared with the bukkit implementation by moving it to commandapi-core.This PR is currently going to the dev/velocity-attempt-2 branch, which seems to have branched off a while ago, so this PR also contains a bunch of newer dev commits.