LPS-53487 Replace ReservedUserIdException with inner class of UserIdException #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the one of this article.
…publisher is removed from a display page
…nd getDDMFormFieldValueRendererAccessor operations to DDMFormFieldType interface
…side arquillian context, cut them out from the TestRule inheritance chain, so that they won't get into the way of TestRule logic extraction
…of UserIdException
|
Just started reviewing :) |
Sent from
|
Pull request submitted to brianchandotcom#23962. |
|
Great job @pei-jung |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @JorgeFerrer,
Here is an update for https://issues.liferay.com/browse/LPS-53409.
I'm not sure if I should just deprecate the ReservedUserIdException class and removed all its usages completely since this exception is not being thrown anywhere in the portal. Yet, I still added a nested class in the UserIdException, just in case if there's any usage for it. Let me know if you prefer this to be removed completely instead. Thanks!