-
-
Notifications
You must be signed in to change notification settings - Fork 255
/
BooleanLiteralAnalyzer.cs
276 lines (239 loc) · 11 KB
/
BooleanLiteralAnalyzer.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
// Copyright (c) Josef Pihrt. All rights reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System;
using System.Collections.Immutable;
using System.Threading;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.Diagnostics;
using Roslynator.CSharp;
namespace Roslynator.CSharp.Analysis
{
[DiagnosticAnalyzer(LanguageNames.CSharp)]
public class BooleanLiteralAnalyzer : BaseDiagnosticAnalyzer
{
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
{
get
{
return ImmutableArray.Create(
DiagnosticDescriptors.RemoveRedundantBooleanLiteral,
DiagnosticDescriptors.SimplifyBooleanComparison,
DiagnosticDescriptors.SimplifyBooleanComparisonFadeOut);
}
}
public override void Initialize(AnalysisContext context)
{
if (context == null)
throw new ArgumentNullException(nameof(context));
base.Initialize(context);
context.EnableConcurrentExecution();
context.RegisterCompilationStartAction(startContext =>
{
if (!startContext.AreAnalyzersSuppressed(DiagnosticDescriptors.RemoveRedundantBooleanLiteral, DiagnosticDescriptors.SimplifyBooleanComparison))
{
startContext.RegisterSyntaxNodeAction(AnalyzeEqualsExpression, SyntaxKind.EqualsExpression);
startContext.RegisterSyntaxNodeAction(AnalyzeNotEqualsExpression, SyntaxKind.NotEqualsExpression);
startContext.RegisterSyntaxNodeAction(AnalyzeLogicalAndExpression, SyntaxKind.LogicalAndExpression);
startContext.RegisterSyntaxNodeAction(AnalyzeLogicalOrExpression, SyntaxKind.LogicalOrExpression);
}
if (!startContext.IsAnalyzerSuppressed(DiagnosticDescriptors.RemoveRedundantBooleanLiteral))
startContext.RegisterSyntaxNodeAction(AnalyzeForStatement, SyntaxKind.ForStatement);
});
}
private static void AnalyzeForStatement(SyntaxNodeAnalysisContext context)
{
var forStatement = (ForStatementSyntax)context.Node;
ExpressionSyntax condition = forStatement.Condition;
if (condition?.Kind() == SyntaxKind.TrueLiteralExpression)
context.ReportDiagnostic(DiagnosticDescriptors.RemoveRedundantBooleanLiteral, condition, condition.ToString());
}
private static void AnalyzeEqualsExpression(SyntaxNodeAnalysisContext context)
{
var binaryExpression = (BinaryExpressionSyntax)context.Node;
ExpressionSyntax left = binaryExpression.Left;
if (left?.IsMissing == false)
{
ExpressionSyntax right = binaryExpression.Right;
if (right?.IsMissing == false)
AnalyzeEqualsNotEquals(context, binaryExpression, left, right, SyntaxKind.FalseLiteralExpression, SyntaxKind.TrueLiteralExpression);
}
}
private static void AnalyzeNotEqualsExpression(SyntaxNodeAnalysisContext context)
{
var binaryExpression = (BinaryExpressionSyntax)context.Node;
ExpressionSyntax left = binaryExpression.Left;
if (left?.IsMissing == false)
{
ExpressionSyntax right = binaryExpression.Right;
if (right?.IsMissing == false)
AnalyzeEqualsNotEquals(context, binaryExpression, left, right, SyntaxKind.TrueLiteralExpression, SyntaxKind.FalseLiteralExpression);
}
}
private static void AnalyzeLogicalAndExpression(SyntaxNodeAnalysisContext context)
{
var binaryExpression = (BinaryExpressionSyntax)context.Node;
ExpressionSyntax left = binaryExpression.Left;
if (left?.IsMissing == false)
{
ExpressionSyntax right = binaryExpression.Right;
if (right?.IsMissing == false)
AnalyzeLogicalAndLogicalOr(context, binaryExpression, left, right, SyntaxKind.TrueLiteralExpression);
}
}
private static void AnalyzeLogicalOrExpression(SyntaxNodeAnalysisContext context)
{
var binaryExpression = (BinaryExpressionSyntax)context.Node;
ExpressionSyntax left = binaryExpression.Left;
if (left?.IsMissing == false)
{
ExpressionSyntax right = binaryExpression.Right;
if (right?.IsMissing == false)
AnalyzeLogicalAndLogicalOr(context, binaryExpression, left, right, SyntaxKind.FalseLiteralExpression);
}
}
private static void AnalyzeEqualsNotEquals(
SyntaxNodeAnalysisContext context,
BinaryExpressionSyntax binaryExpression,
ExpressionSyntax left,
ExpressionSyntax right,
SyntaxKind kind,
SyntaxKind kind2)
{
SyntaxKind leftKind = left.Kind();
if (leftKind == kind)
{
switch (AnalyzeExpression(right, context.SemanticModel, context.CancellationToken))
{
case AnalysisResult.Boolean:
{
SimplifyBooleanComparisonAnalysis.ReportDiagnostic(context, binaryExpression, left, right, fadeOut: true);
break;
}
case AnalysisResult.LogicalNotWithNullableBoolean:
{
SimplifyBooleanComparisonAnalysis.ReportDiagnostic(context, binaryExpression, left, right, fadeOut: false);
break;
}
}
}
else if (leftKind == kind2)
{
switch (AnalyzeExpression(right, context.SemanticModel, context.CancellationToken))
{
case AnalysisResult.Boolean:
{
RemoveRedundantBooleanLiteralAnalysis.ReportDiagnostic(context, binaryExpression, left, right);
break;
}
case AnalysisResult.LogicalNotWithNullableBoolean:
{
SimplifyBooleanComparisonAnalysis.ReportDiagnostic(context, binaryExpression, left, right, fadeOut: false);
break;
}
}
}
else
{
SyntaxKind rightKind = right.Kind();
if (rightKind == kind)
{
switch (AnalyzeExpression(left, context.SemanticModel, context.CancellationToken))
{
case AnalysisResult.Boolean:
{
SimplifyBooleanComparisonAnalysis.ReportDiagnostic(context, binaryExpression, left, right, fadeOut: true);
break;
}
case AnalysisResult.LogicalNotWithNullableBoolean:
{
SimplifyBooleanComparisonAnalysis.ReportDiagnostic(context, binaryExpression, left, right, fadeOut: false);
break;
}
}
}
else if (rightKind == kind2)
{
switch (AnalyzeExpression(left, context.SemanticModel, context.CancellationToken))
{
case AnalysisResult.Boolean:
{
RemoveRedundantBooleanLiteralAnalysis.ReportDiagnostic(context, binaryExpression, left, right);
break;
}
case AnalysisResult.LogicalNotWithNullableBoolean:
{
SimplifyBooleanComparisonAnalysis.ReportDiagnostic(context, binaryExpression, left, right, fadeOut: false);
break;
}
}
}
}
}
private static void AnalyzeLogicalAndLogicalOr(
SyntaxNodeAnalysisContext context,
BinaryExpressionSyntax binaryExpression,
ExpressionSyntax left,
ExpressionSyntax right,
SyntaxKind kind)
{
if (left.IsKind(kind)
|| right.IsKind(kind))
{
RemoveRedundantBooleanLiteralAnalysis.ReportDiagnostic(context, binaryExpression, left, right);
}
}
private static AnalysisResult AnalyzeExpression(
ExpressionSyntax expression,
SemanticModel semanticModel,
CancellationToken cancellationToken)
{
switch (expression.Kind())
{
case SyntaxKind.TrueLiteralExpression:
case SyntaxKind.FalseLiteralExpression:
return AnalysisResult.BooleanLiteral;
case SyntaxKind.LogicalNotExpression:
{
var logicalNot = (PrefixUnaryExpressionSyntax)expression;
ExpressionSyntax operand = logicalNot.Operand;
if (operand != null)
{
ITypeSymbol typeSymbol = semanticModel.GetTypeInfo(operand, cancellationToken).ConvertedType;
if (typeSymbol != null)
{
if (typeSymbol.SpecialType == SpecialType.System_Boolean)
{
return AnalysisResult.Boolean;
}
else if (typeSymbol.IsNullableOf(SpecialType.System_Boolean))
{
return AnalysisResult.LogicalNotWithNullableBoolean;
}
}
}
break;
}
default:
{
if (semanticModel
.GetTypeInfo(expression, cancellationToken)
.ConvertedType?
.SpecialType == SpecialType.System_Boolean)
{
return AnalysisResult.Boolean;
}
break;
}
}
return AnalysisResult.None;
}
private enum AnalysisResult
{
None = 0,
BooleanLiteral = 1,
Boolean = 2,
LogicalNotWithNullableBoolean = 3,
}
}
}