-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #10 from JosephDuffy/api-improvements
API Improvements
- Loading branch information
Showing
6 changed files
with
773 additions
and
41 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
106 changes: 106 additions & 0 deletions
106
Sources/HashableMacroMacros/LabeledExprListSyntax+extensions.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| import SwiftSyntax | ||
|
|
||
| extension LabeledExprListSyntax { | ||
| mutating func appendAndFixTrailingComma(expression: LabeledExprSyntax) { | ||
| if let lastIndex = indices.last { | ||
| // Attempt to keep some formatting, e.g. if each parameter | ||
| // placed on a new line. | ||
| let trailingTrivia = self[lastIndex].trailingComma?.trailingTrivia ?? .space | ||
| self[lastIndex].trailingComma = .commaToken(trailingTrivia: trailingTrivia) | ||
| } | ||
|
|
||
| append(expression) | ||
| } | ||
|
|
||
| mutating func addOrUpdateArgument( | ||
| label: String, | ||
| expression: some ExprSyntaxProtocol, | ||
| allArguments: LabeledExprListSyntax | ||
| ) { | ||
| let label = TokenSyntax.identifier(label) | ||
|
|
||
| var argumentExpression = LabeledExprSyntax( | ||
| label: label, | ||
| colon: .colonToken(trailingTrivia: .space), | ||
| expression: expression | ||
| ) | ||
|
|
||
| guard !isEmpty else { | ||
| insert( | ||
| argumentExpression, | ||
| at: startIndex | ||
| ) | ||
| return | ||
| } | ||
|
|
||
| if let existingArgumentIndex = firstIndex(where: { $0.label?.text == label.text }) { | ||
| self[existingArgumentIndex].expression = ExprSyntax(expression) | ||
| } else if let indexInAllArguments = allArguments.firstIndex(where: { $0.label?.text == label.text }) { | ||
| let possibleIndicesInAllArguments = allArguments.indices.prefix(while: { $0 != indexInAllArguments }) | ||
| // Work backwards until we find the index in `self` for the first | ||
| // parameter that comes before this new one. | ||
| for priorIndex in possibleIndicesInAllArguments.reversed() { | ||
| let defaultArgument = allArguments[priorIndex] | ||
|
|
||
| if let indexBeforeIndexToInsertAt = firstIndex(where: { $0.label?.text == defaultArgument.label?.text }) { | ||
| let indexToInsertAt = index(after: indexBeforeIndexToInsertAt) | ||
| if indexToInsertAt != endIndex { | ||
| argumentExpression.trailingComma = .commaToken(trailingTrivia: .space) | ||
| } else { | ||
| self[indexBeforeIndexToInsertAt].trailingComma = .commaToken(trailingTrivia: .space) | ||
| } | ||
| insert( | ||
| argumentExpression, | ||
| at: indexToInsertAt | ||
| ) | ||
| return | ||
| } | ||
| } | ||
|
|
||
| // Fallback to adding it at the start | ||
| argumentExpression.trailingComma = .commaToken(trailingTrivia: .space) | ||
| insert( | ||
| argumentExpression, | ||
| at: startIndex | ||
| ) | ||
| } else { | ||
| // Fallback to appending when the argument is not known. | ||
| appendAndFixTrailingComma( | ||
| expression: argumentExpression | ||
| ) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| extension LabeledExprListSyntax { | ||
| static var allHashableArguments: LabeledExprListSyntax { | ||
| [ | ||
| LabeledExprSyntax( | ||
| label: "finalHashInto", | ||
| expression: BooleanLiteralExprSyntax(booleanLiteral: true) | ||
| ), | ||
| LabeledExprSyntax( | ||
| label: "isEqualToTypeFunctionName", | ||
| expression: MemberAccessExprSyntax( | ||
| declName: DeclReferenceExprSyntax( | ||
| baseName: .identifier("automatic") | ||
| ) | ||
| ) | ||
| ), | ||
| LabeledExprSyntax( | ||
| label: "allowEmptyImplementation", | ||
| expression: BooleanLiteralExprSyntax(booleanLiteral: false) | ||
| ), | ||
| LabeledExprSyntax( | ||
| label: "_disableNSObjectSubclassSupport", | ||
| expression: BooleanLiteralExprSyntax(booleanLiteral: false) | ||
| ), | ||
| ] | ||
| } | ||
| mutating func addOrUpdateHashableArgument( | ||
| label: String, | ||
| expression: some ExprSyntaxProtocol | ||
| ) { | ||
| addOrUpdateArgument(label: label, expression: expression, allArguments: .allHashableArguments) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.