Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of Windows illegal quotes in sample file names #20

Merged
merged 2 commits into from
Oct 12, 2020

Conversation

IceBerge421
Copy link
Contributor

@IceBerge421 IceBerge421 commented Oct 11, 2020

Overview

Summary

Two files in the sample folder contain quotes in the title, resulting in checkout failures in repo clones. This fix simply removes the quotes from the two sample file names to make repo clones possible again.

Motivation/Context

I wasn't able to clone the repository, so I forked to fix this. I also saw someone else had posted a bug.

New Dependencies

None

Issue Fix or Enhancement Request

Fixes #18 which was causing checkout errors.

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)

Breaking Change

N/A

List All Changes That Have Been Made

  • Removed the quotes around "good" in two filenames

How Has This Been Tested?

N/A

Test Configuration

N/A

Dependencies

N/A

Checklist

Tip: You can check off items by writing an "x" in the brackets, e.g. [x].

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code, including testing to ensure my fix is effective or that my feature works.
  • My changes generate no new warnings.
  • I have commented my code, providing a summary of the functionality of each method, particularly in areas that may be hard to understand.
  • I have made corresponding changes to the documentation.
  • [] I have performed a self-review of this Pull Request template, ensuring the Markdown file renders correctly.

… c-Opinion_ How is Python a good language_-10-results.json
…ion_ How is Python a good language_-RAW.json
@codecov-io
Copy link

codecov-io commented Oct 11, 2020

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   73.11%   73.11%           
=======================================
  Files          25       25           
  Lines        2005     2005           
=======================================
  Hits         1466     1466           
  Misses        539      539           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ff1a46...fd36cfe. Read the comment docs.

@JosephLai241 JosephLai241 merged commit 708fc37 into JosephLai241:master Oct 12, 2020
@JosephLai241
Copy link
Owner

Thank you for fixing this bug! I have not been able to get around to fixing the problem, glad you could fix it for me lol. I will add you to the Contributors table on the README.

This pull request also reminded me of some updates I need to implement in the existing template while I made some changes to yours. So thanks for that as well! 😂

skiwheelr pushed a commit to skiwheelr/URS that referenced this pull request Feb 25, 2021
Get rid of Windows illegal quotes in sample file names
@JosephLai241 JosephLai241 added the bugfix Fixed a bug label Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixed a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows cloning error
3 participants