Do not remove user's role and abilities when softDeleting #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind adding a test for this? |
|
the test fails only because of old php versions in travis file |
|
Can you rebase then?
|
|
I don't know how to do that :D for real now! Give a man a fish and you feed him for a day, |
|
Here's the rebased commit with additional tests: master...trawiasty:feature/soft-deletes-support @czapio92 If you like the tests please rebase your's commit and cherry-pick mine. |
|
@trawiasty I like this tests, cherry picked. @JosephSilber notice me. |
|
I rebased, tweaked and merged. |
|
Thank you both 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to issue #485.