Alternative line numbering and comment fix. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshCheek
added a commit
that referenced
this pull request
Jan 12, 2012
Alternative line numbering and comment fix.
|
Nice! Thank you, I was so frustrated by that one! Also didn't know $< was ARGF. Sorry you have to dl my entire play dir to get that, I'm not smart enough to figure out submodules >.< |
|
Looks like Github has an option for forking the project and editing the file online. But I decided against it as I was afraid it'd send pull request instantly. Anyway, thank you for such a great collection. I think I'll dig in some other stuff from that repo later. P.S. Shorter solution (without regexps) for trimming trailing spaces: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added alternative version for line numbering per file. It might have issues with multi-byte encoding as
ARGF#posreturns position in bytes. To work properly in that casesString#bytesizecan be used instead of regularString#size.In addition fixed comment for removing consecutive blank lines. I was thinking for a while how that can remove consecutive duplicate lines and finally realized that you speaking about blank lines.