Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should work when the exception doesn't have a backtrace #140

Open
3 tasks
JoshCheek opened this issue Sep 4, 2018 · 0 comments
Open
3 tasks

Should work when the exception doesn't have a backtrace #140

JoshCheek opened this issue Sep 4, 2018 · 0 comments

Comments

@JoshCheek
Copy link
Owner

In #134 there was a bug in Ruby where the exception didn't have a backtrace (I think because it never got raised, it just got set somehow, so then it went into the at_exit block which passed it to the lib).

Prob no way to truly this without writing C code (since I'll need to override the methods with refinements, anyway), and it is just compensating for a bug in the interpreter, but still, it shouldn't explode when this happens.

  • Doesn't explode when Exception#backtrace returns nil
  • Maybe it should use the Safe refinements in the matrix?
  • Tangentially related: maybe try a test where it just straight deletes every method off of every class and show that it still works. That might be the best way to avoid regressions from hostile environments that I haven't thought of?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant