Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed landscape on ios #26

Merged
merged 2 commits into from
Jun 27, 2017
Merged

fixed landscape on ios #26

merged 2 commits into from
Jun 27, 2017

Conversation

dobjek
Copy link
Contributor

@dobjek dobjek commented Jun 23, 2017

@TheOriginalJosh some minor additions/fixes

@JoshDSommer
Copy link
Owner

Good catch! I actually did the exact same thing last night before I published the updated.

https://github.com/TheOriginalJosh/nativescript-ngx-slides/blob/master/slides/app/slides/slides.component.ts#L125

going to close this for now. Thank you for this though I appreciate it.

@dobjek
Copy link
Contributor Author

dobjek commented Jun 23, 2017

@TheOriginalJosh there is more to it, remove this.applySwipe from:

if (this.currentSlide) {
this.positionSlides(this.currentSlide);
this.applySwipe(this.pageWidth);
}

@JoshDSommer JoshDSommer reopened this Jun 23, 2017
@JoshDSommer
Copy link
Owner

@dobjek Ok cool, I'll merge it in tonight! thanks again!

@JoshDSommer JoshDSommer merged commit 5864605 into JoshDSommer:master Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants