Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Textual #154

Merged
merged 52 commits into from
Nov 26, 2022
Merged

Switch to Textual #154

merged 52 commits into from
Nov 26, 2022

Conversation

JoshKarpel
Copy link
Owner

@JoshKarpel JoshKarpel commented Nov 10, 2022

Using Textual instead of rich.Live plus hacks!

@JoshKarpel JoshKarpel added enhancement New feature or request dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Nov 10, 2022
@JoshKarpel JoshKarpel self-assigned this Nov 10, 2022
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 94.4% // Head: 82.1% // Decreases project coverage by -12.2% ⚠️

Coverage data is based on head (b10e8d1) compared to base (d7b9d44).
Patch coverage: 70.5% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #154      +/-   ##
========================================
- Coverage   94.4%   82.1%   -12.3%     
========================================
  Files         42      30      -12     
  Lines       1419     750     -669     
  Branches     110      83      -27     
========================================
- Hits        1340     616     -724     
- Misses        74     134      +60     
+ Partials       5       0       -5     
Impacted Files Coverage Δ
spiel/widgets/minislides.py 34.2% <34.2%> (ø)
spiel/widgets/bindings.py 46.4% <46.4%> (ø)
spiel/widgets/slide.py 58.0% <58.0%> (ø)
spiel/screens/slide.py 58.3% <58.3%> (ø)
spiel/app.py 61.7% <61.7%> (ø)
spiel/widgets/widget.py 66.6% <66.6%> (ø)
spiel/widgets/footer.py 69.2% <69.2%> (ø)
spiel/screens/help.py 73.3% <73.3%> (ø)
spiel/screens/deck.py 81.8% <81.8%> (ø)
spiel/__main__.py 100.0% <100.0%> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JoshKarpel JoshKarpel marked this pull request as ready for review November 26, 2022 01:31
@JoshKarpel JoshKarpel merged commit 9277169 into main Nov 26, 2022
@JoshKarpel JoshKarpel deleted the textual-v2 branch November 26, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use watchfiles instead of watchdog Support for Windows
1 participant