-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use source code for demo directly in demo #194
Use source code for demo directly in demo #194
Conversation
Definitely worth it! As you guessed, that line was a leftover from my attempt to do pretty much the same thing. I got flummoxed by the indentation, which it looks like you've solved here. Will take a closer look later! |
Codecov ReportBase: 82.5% // Head: 82.5% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
=======================================
- Coverage 82.5% 82.5% -0.1%
=======================================
Files 33 33
Lines 843 842 -1
Branches 96 96
=======================================
- Hits 696 695 -1
Misses 147 147
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@edrogers I pushed up some new commits to your branch - I took inspiration from your approach on the indentation, but stitched things together with |
Looking through the source code of the demo deck, I found the unused variable
edit_function_src
in the bindings slide:I suspect this was originally intended to be a way to display some of the module's source directly in the a code-block on the slide. This seems like a good idea, so I tried following through on it. I think the result de-duplicates the source code without introducing too much messiness.
The slide deck produced is ultimately unchanged, so it's just a style preference. Let me know if you think it's worth it.
Tasks