Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch un-renderable slide content at runtime #202

Merged
merged 5 commits into from
Jan 16, 2023

Conversation

JoshKarpel
Copy link
Owner

@JoshKarpel JoshKarpel commented Jan 16, 2023

Tasks

  • Updated changelog.
  • Updated documentation.

@JoshKarpel JoshKarpel self-assigned this Jan 16, 2023
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 82.9% // Head: 94.1% // Increases project coverage by +11.1% 🎉

Coverage data is based on head (0af7ad3) compared to base (de3a57d).
Patch coverage: 98.8% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #202      +/-   ##
========================================
+ Coverage   82.9%   94.1%   +11.1%     
========================================
  Files         33      35       +2     
  Lines        833     920      +87     
  Branches      94     110      +16     
========================================
+ Hits         691     866     +175     
+ Misses       142      47      -95     
- Partials       0       7       +7     
Impacted Files Coverage Δ
spiel/app.py 75.8% <50.0%> (+14.7%) ⬆️
spiel/widgets/slide.py 94.2% <100.0%> (+36.2%) ⬆️
spiel/widgets/widget.py 100.0% <100.0%> (+33.3%) ⬆️
tests/test_app.py 100.0% <100.0%> (ø)
tests/test_slide_widget.py 100.0% <100.0%> (ø)
spiel/screens/slide.py 73.9% <0.0%> (+17.3%) ⬆️
spiel/screens/deck.py 100.0% <0.0%> (+18.1%) ⬆️
spiel/screens/help.py 100.0% <0.0%> (+26.6%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JoshKarpel JoshKarpel marked this pull request as ready for review January 16, 2023 18:14
@JoshKarpel JoshKarpel merged commit 99961a3 into main Jan 16, 2023
@JoshKarpel JoshKarpel deleted the catch-unrenderable-content branch January 16, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant