Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slide Transitions #207

Merged
merged 31 commits into from
Feb 19, 2023
Merged

Slide Transitions #207

merged 31 commits into from
Feb 19, 2023

Conversation

JoshKarpel
Copy link
Owner

@JoshKarpel JoshKarpel commented Jan 19, 2023

Resolves #209 , since I ran into that problem while testing this due to Textual bugs.

Bumps to v0.5.0 since this is a major new feature that changes the arguments of various public functions (to add support for transition configuration).

Tasks

  • Updated changelog.
  • Updated documentation.

@JoshKarpel JoshKarpel added the enhancement New feature or request label Jan 19, 2023
@JoshKarpel JoshKarpel self-assigned this Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 21, 2023

Codecov Report

Base: 93.7% // Head: 87.8% // Decreases project coverage by -5.9% ⚠️

Coverage data is based on head (44527cc) compared to base (3d4ebec).
Patch coverage: 77.5% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #207     +/-   ##
=======================================
- Coverage   93.7%   87.8%   -5.9%     
=======================================
  Files         35      44      +9     
  Lines        928    1169    +241     
  Branches     111     129     +18     
=======================================
+ Hits         870    1027    +157     
- Misses        49     134     +85     
+ Partials       9       8      -1     
Impacted Files Coverage Δ
tests/cli/test_demo.py 100.0% <ø> (ø)
tests/renderables/test_image.py 100.0% <ø> (ø)
tests/utils/test_chunks.py 100.0% <ø> (ø)
tests/utils/test_clamp.py 100.0% <ø> (ø)
tests/utils/test_filter_join.py 100.0% <ø> (ø)
tests/widgets/test_slide_widget.py 100.0% <ø> (ø)
spiel/widgets/slide.py 94.2% <33.3%> (ø)
spiel/screens/transition.py 50.0% <50.0%> (ø)
spiel/widgets/fixed_slide.py 53.1% <53.1%> (ø)
spiel/app.py 70.3% <66.6%> (-6.3%) ⬇️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JoshKarpel
Copy link
Owner Author

JoshKarpel commented Jan 23, 2023

Blocked by Textualize/textual#1632 ; need to pin back to textual==0.9.1 temporarily to get the branch working, but that breaks watch.

@JoshKarpel JoshKarpel marked this pull request as ready for review February 19, 2023 19:06
@JoshKarpel JoshKarpel enabled auto-merge (squash) February 19, 2023 19:06
@JoshKarpel JoshKarpel merged commit d0f5505 into main Feb 19, 2023
@JoshKarpel JoshKarpel deleted the transitions branch February 19, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set timeout for GitHub Actions jobs
1 participant