Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(): update to NodeJS 10 or OpenSSL 1.1.0 (closes #167) #169

Merged
merged 2 commits into from
May 29, 2018

Conversation

jkuri
Copy link
Contributor

@jkuri jkuri commented May 14, 2018

I made it backward compatible with previous NodeJS/OpenSSL versions.

@jkuri jkuri mentioned this pull request May 14, 2018
@lognaturel
Copy link

lognaturel commented May 25, 2018

Confirmed working well on macOS 10.13.4, node v10.2.1. Thanks, @jkuri!

@JoshKaufman What can users do to help get this ready for merge?

@deluxor
Copy link

deluxor commented May 25, 2018

Working perfectly on Linux, with latest Node 10.2.1 and NPM 6.1.0
Good job!

> ursa@0.9.4 install /home/deluxor/home/Loqr/lcp-node-sdk/node_modules/ursa
> node-gyp rebuild

make: Entering directory '/home/deluxor/home/Loqr/lcp-node-sdk/node_modules/ursa/build'
  CXX(target) Release/obj.target/ursaNative/src/ursaNative.o
  SOLINK_MODULE(target) Release/obj.target/ursaNative.node
  COPY Release/ursaNative.node
make: Leaving directory '/home/deluxor/home/Loqr/lcp-node-sdk/node_modules/ursa/build'
updated 3 packages and audited 111 packages in 9.455s

@LoganDark
Copy link

LoganDark commented May 26, 2018

It works, so merge it please, production code won't run because I can't build this on a Compute Engine instance.

@JoshKaufman JoshKaufman merged commit eb71819 into JoshKaufman:master May 29, 2018
@LoganDark
Copy link

Thank you!

@jkuri
Copy link
Contributor Author

jkuri commented Jun 1, 2018

@JoshKaufman thanks for merging, can you also publish a new version to npm please?

@mtgto
Copy link

mtgto commented Jul 7, 2018

I'm also waiting for publishing 😂😂😂

@bmunkholm
Copy link

Please @JoshKaufman can publish? Or alternatively, give others rights to do so? It's highly preferred from forking and maintaining that.

@delfuego
Copy link

delfuego commented Nov 6, 2018

Will this ever make it to npm? It's much harder to do CI builds without there being a dependable npm source for this fix.

@JonasRech
Copy link

@quartzjer as the new maintainer, could you please do a publish to NPM? It can't be so hard...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants