Remove types, tests & logic related to the SDK-binding feature (Azure…

…#1374)
JoshLove-msft · Feb 23, 2023 · eac5b19 · eac5b19
1 parent c974502
commit eac5b19
Show file tree

Hide file tree

Showing 13 changed files with 8 additions and 577 deletions.
diff --git a/extensions/Worker.Extensions.Abstractions/src/SupportsDeferredBindingAttribute.cs b/extensions/Worker.Extensions.Abstractions/src/SupportsDeferredBindingAttribute.cs
diff --git a/extensions/Worker.Extensions.Storage.Blobs/src/BlobInputAttribute.cs b/extensions/Worker.Extensions.Storage.Blobs/src/BlobInputAttribute.cs
@@ -5,7 +5,6 @@
 
 namespace Microsoft.Azure.Functions.Worker
 {
-    [SupportsDeferredBinding]
     public sealed class BlobInputAttribute : InputBindingAttribute
     {
         private readonly string _blobPath;

diff --git a/extensions/Worker.Extensions.Storage.Blobs/src/BlobStorageConverter.cs b/extensions/Worker.Extensions.Storage.Blobs/src/BlobStorageConverter.cs
diff --git a/extensions/Worker.Extensions.Storage.Blobs/src/BlobTriggerAttribute.cs b/extensions/Worker.Extensions.Storage.Blobs/src/BlobTriggerAttribute.cs
@@ -5,7 +5,6 @@
 
 namespace Microsoft.Azure.Functions.Worker
 {
-    [SupportsDeferredBinding]
     public sealed class BlobTriggerAttribute : TriggerBindingAttribute
     {
         private readonly string _blobPath;

diff --git a/extensions/Worker.Extensions.Storage.Blobs/src/StorageExtensionStartup.cs b/extensions/Worker.Extensions.Storage.Blobs/src/StorageExtensionStartup.cs
@@ -24,11 +24,6 @@ public override void Configure(IFunctionsWorkerApplicationBuilder applicationBui
             applicationBuilder.Services.AddAzureClientsCore(); // Adds AzureComponentFactory
             applicationBuilder.Services.AddOptions<BlobStorageBindingOptions>();
             applicationBuilder.Services.AddSingleton<IConfigureOptions<BlobStorageBindingOptions>, BlobStorageBindingOptionsSetup>();
-
-            applicationBuilder.Services.Configure<WorkerOptions>((workerOption) =>
-            {
-                workerOption.InputConverters.RegisterAt<BlobStorageConverter>(0);
-            });
         }
     }
 }
diff --git a/src/DotNetWorker.Core/CollectionModelBindingData.cs b/src/DotNetWorker.Core/CollectionModelBindingData.cs
diff --git a/src/DotNetWorker.Core/ModelBindingData.cs b/src/DotNetWorker.Core/ModelBindingData.cs
diff --git a/src/DotNetWorker.Grpc/Features/GrpcFunctionBindingsFeature.cs b/src/DotNetWorker.Grpc/Features/GrpcFunctionBindingsFeature.cs
@@ -124,8 +124,6 @@ public void SetOutputBinding(string name, object value)
             TypedData.DataOneofCase.CollectionString => typedData.CollectionString.String,
             TypedData.DataOneofCase.CollectionDouble => typedData.CollectionDouble.Double,
             TypedData.DataOneofCase.CollectionSint64 => typedData.CollectionSint64.Sint64,
-            TypedData.DataOneofCase.ModelBindingData => new GrpcModelBindingData(typedData.ModelBindingData),
-            TypedData.DataOneofCase.CollectionModelBindingData => new GrpcCollectionModelBindingData(typedData.CollectionModelBindingData),
             _ => throw new NotSupportedException($"{typedData.DataCase} is not supported."),
         };
     }

diff --git a/src/DotNetWorker.Grpc/GrpcCollectionModelBindingData.cs b/src/DotNetWorker.Grpc/GrpcCollectionModelBindingData.cs
diff --git a/src/DotNetWorker.Grpc/GrpcModelBindingData.cs b/src/DotNetWorker.Grpc/GrpcModelBindingData.cs