Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recipe using Substrate v2.0 #385

Merged
merged 13 commits into from
Oct 1, 2020
Merged

Recipe using Substrate v2.0 #385

merged 13 commits into from
Oct 1, 2020

Conversation

jimmychu0807
Copy link
Collaborator

I know, a big one.

  • Updated to Substrate v2
  • cargo build --all and cargo tests --all passes
  • Remove -rc6 from Substrate rustdoc links
  • temporarily suspend playground template CI job (so all CI actions pass)

wheresaddie
wheresaddie approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@wheresaddie wheresaddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty jimmy

@jimmychu0807 jimmychu0807 merged commit a8f6e74 into master Oct 1, 2020
@jimmychu0807 jimmychu0807 deleted the jimmy/v2.0.0 branch October 1, 2020 08:45
@jimmychu0807
Copy link
Collaborator Author

Yes, all CI passes 😄

@danforbes
Copy link
Contributor

Thank you, Jimmy! 🎉

@JoshOrndorff
Copy link
Owner

Congrats @jimmychu0807 You just levelled up as a Substrate dev <3

@jimmychu0807
Copy link
Collaborator Author

Congrats @jimmychu0807 You just levelled up as a Substrate dev <3

what, you are telling me I wasn't a substrate dev before?

@JoshOrndorff
Copy link
Owner

Of course you were. I just meant this is a big not-all-in-the-runtime update. So you get new reputation.

@JoshOrndorff JoshOrndorff mentioned this pull request Apr 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wheresaddie wheresaddie wheresaddie approved these changes

@danforbes danforbes Awaiting requested review from danforbes

@riusricardo riusricardo Awaiting requested review from riusricardo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jimmychu0807 @danforbes @JoshOrndorff @wheresaddie