Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change import in child-trie module #90

Merged
merged 26 commits into from Nov 20, 2019

Conversation

JoshOrndorff
Copy link
Owner

Previously CHILD_STORAGE_KEY_PREFIX was imported from a specific branch of upstream Substrate. This caused build issues which I discovered when working on the CI. This PR pulls that constant from the same revision as all the other dependencies in the recipes.

This branch is based off the tip (at the time of writing) of #72 so it should not be merged unless that is also merged. Otherwise it can easily be cherry-picked or manually re-applied.

@JoshOrndorff
Copy link
Owner Author

So, just to clarify, only the very last commit is actually relevant here.

Copy link
Contributor

@4meta5 4meta5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@JoshOrndorff JoshOrndorff merged commit 89de89d into master Nov 20, 2019
@JoshOrndorff JoshOrndorff deleted the joshy-child-tree-dependencies branch February 3, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants