Some Issue fixes #189
Closed
Some Issue fixes #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#] Fixed some engine traces failing. (some traces the engine uses to determent if you can unduck failed) [#] Fixed CheckCollision checking collisions even if collisions are disabled(IsCollisionEnabled = false) [#] JoltPhysicsObject::GetName() now returns a proper name instead of "NoName" In Gmod If you used tostring(Entity(1):GetPhysicsObject()) it returned NoName instead of player_stand or player_crouch.
|
The reason the portal back exists right now is because with it enabled, walking up static props ends up with the player getting stuck sometimes. |
|
I will test a bit around with it. |
[+] Added install.md to help users install Volt. [#] Fixed a crash [#] Set m_bSimulating to true after m_ContactListener.PostSimulationFrame()
|
Can you split these fixes out into separate MRs? |
|
Every fix or some specific fixes? |
|
Please all of the fixes, or at least into separate commits. |
Will be done. Gimme a few min. |
|
Should be done. Should I make a separate PR for each future fix, or is it okay if they have their separate commit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[+] Added install.md to help users install Volt.
[#] Fixed some engine traces failing.
(some traces the engine uses to determent if you can unduck failed)
[#] Fixed CheckCollision checking collisions even if collisions are disabled(IsCollisionEnabled = false)
[#] JoltPhysicsObject::GetName() now returns a proper name instead of "NoName"
In Gmod If you used tostring(Entity(1):GetPhysicsObject()) it returned NoName instead of player_stand or player_crouch.
[#] Fixed a crash
Related issues:
fixes #128
fixes #164
fixes #102
fixes #137
fixes #85
fixes #125 (Read the install.md)
Over the next few days, I want to fix more issues.