Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FHX (Ferentus, Herrcot, Xiones) Issues #306

Closed
cynicer opened this issue Aug 17, 2019 · 14 comments
Closed

FHX (Ferentus, Herrcot, Xiones) Issues #306

cynicer opened this issue Aug 17, 2019 · 14 comments

Comments

@cynicer
Copy link

cynicer commented Aug 17, 2019

We're a small group of developers reviving an old Korean MMO by reimplementing the game server. We're rather advanced on the server side, but still have issues with the old game client. The game is based on DX9 and GDI and runs on Windows 10, but has several issues (gradual frame drop, crashes on NVIDIA drivers and extreme frame drop on UI with lots of text). D9VK solves all of this issues, the game runs better than ever (great work, thanks!), but a few new problems arise (also see apitrace):

  • Lighting is rendered wrong (Fixed as of 8490b27)
  • Skybox is not rendered (Fixed)
  • Mouse is "caught" in the game, until it reaches a UI element, where it can be moved freely. Makes it unuseable. (Fixed by c424300)
  • Water reflections are completely flat
  • Fog is not drawn (Fixed as of eba88d0)

It would be awesome if you guys were able to figures out the issue. This would give a couple hundreds of people the chance to enjoy the game smoothly.

With D9VK:
Client_2019-08-17_10-24-07
Client_2019-08-17_10-24-56

Without D9VK:
Client_2019-08-17_10-27-34
Client_2019-08-17_10-28-11

Software information

FHX (Ferentus, Herrcot or Xiones) released in 2004 and closed in 2008.

System information

  • GPU: NVIDIA GTX 1080
  • Driver: 430.86
  • Wine version: - (latest Windows 10)
  • DXVK version: master (2b6f011)

Apitrace file(s)

https://drive.google.com/open?id=1vVGpp30OkO32Cf7zEcv60DxgfKLdYu4F

Log files

@cynicer
Copy link
Author

cynicer commented Aug 19, 2019

While going through the logs I just noticed that the fog rendering is missing as well. So I guess the problems are:

  • Missing render states for fog (D3DRS_FOGDENSITY, D3DRS_FOGCOLOR, D3DRS_FOGTABLEMODE, D3DRS_FOGSTART, D3DRS_FOGEND, D3DRS_DITHERENABLE)
  • Missing environmental lighting support (D3DTOP_BUMPENVMAPLUMINANCE)
  • Missing AL16 and R16 format support (Unknown format encountered: 909200449 warn: ConvertFormat: Unknown format encountered: 909201952)

The last one confuses be, as you guys already seem to have included support for those formats in #155

Another question is: what causes the mouse to not work properly ingame?

@cynicer
Copy link
Author

cynicer commented Aug 22, 2019

As of eba88d0 the fog renders now seemingly correctly.

Client_2019-08-22_22-16-14

Thanks for your effort!

@cynicer
Copy link
Author

cynicer commented Aug 25, 2019

Lighting seems now correct on master. The sky is still missing and the mouse is still almost unusable (jumps back to old location). Very good work so far!

Client_2019-08-25_13-40-25

Client_d3d9.log

Joshua-Ashton added a commit that referenced this issue Aug 25, 2019
I was not able to find an instance
where the cursor update was not immediate.

Fullscreen + Windowed seem to have the same
behaviour here.

Hence we ignore the flag D3DCURSOR_IMMEDIATE_UPDATE.

Fixes the mouse part of #306
Joshua-Ashton added a commit that referenced this issue Sep 7, 2019
I was not able to find an instance
where the cursor update was not immediate.

Fullscreen + Windowed seem to have the same
behaviour here.

Hence we ignore the flag D3DCURSOR_IMMEDIATE_UPDATE.

Fixes the mouse part of #306
Joshua-Ashton added a commit that referenced this issue Sep 21, 2019
I was not able to find an instance
where the cursor update was not immediate.

Fullscreen + Windowed seem to have the same
behaviour here.

Hence we ignore the flag D3DCURSOR_IMMEDIATE_UPDATE.

Fixes the mouse part of #306
@cynicer cynicer changed the title FHX (Ferentus, Herrcot, Xiones): Lighting and mouse not working FHX (Ferentus, Herrcot, Xiones): Sky and reflections not rendered Sep 23, 2019
Joshua-Ashton added a commit that referenced this issue Sep 24, 2019
I was not able to find an instance
where the cursor update was not immediate.

Fullscreen + Windowed seem to have the same
behaviour here.

Hence we ignore the flag D3DCURSOR_IMMEDIATE_UPDATE.

Fixes the mouse part of #306
Joshua-Ashton added a commit that referenced this issue Sep 29, 2019
I was not able to find an instance
where the cursor update was not immediate.

Fullscreen + Windowed seem to have the same
behaviour here.

Hence we ignore the flag D3DCURSOR_IMMEDIATE_UPDATE.

Fixes the mouse part of #306
Joshua-Ashton added a commit that referenced this issue Oct 8, 2019
I was not able to find an instance
where the cursor update was not immediate.

Fullscreen + Windowed seem to have the same
behaviour here.

Hence we ignore the flag D3DCURSOR_IMMEDIATE_UPDATE.

Fixes the mouse part of #306
Joshua-Ashton added a commit that referenced this issue Oct 13, 2019
I was not able to find an instance
where the cursor update was not immediate.

Fullscreen + Windowed seem to have the same
behaviour here.

Hence we ignore the flag D3DCURSOR_IMMEDIATE_UPDATE.

Fixes the mouse part of #306
Joshua-Ashton added a commit that referenced this issue Oct 16, 2019
I was not able to find an instance
where the cursor update was not immediate.

Fullscreen + Windowed seem to have the same
behaviour here.

Hence we ignore the flag D3DCURSOR_IMMEDIATE_UPDATE.

Fixes the mouse part of #306
@Joshua-Ashton
Copy link
Owner

Is this still an issue?

@cynicer
Copy link
Author

cynicer commented Oct 19, 2019

Retested with master (d6f5ec8). The mentioned issues (missing/wrong sky and water reflections and still present). Do you need any data? Is there anything I can provide which helps?

@CME42
Copy link
Contributor

CME42 commented Oct 19, 2019

I guess the flat water reflection is probably related to:
warn: D3DTOP_BUMPENVMAPLUMINANCE: not implemented

Joshua-Ashton added a commit that referenced this issue Oct 28, 2019
I was not able to find an instance
where the cursor update was not immediate.

Fullscreen + Windowed seem to have the same
behaviour here.

Hence we ignore the flag D3DCURSOR_IMMEDIATE_UPDATE.

Fixes the mouse part of #306
Joshua-Ashton added a commit that referenced this issue Nov 9, 2019
I was not able to find an instance
where the cursor update was not immediate.

Fullscreen + Windowed seem to have the same
behaviour here.

Hence we ignore the flag D3DCURSOR_IMMEDIATE_UPDATE.

Fixes the mouse part of #306
Joshua-Ashton added a commit that referenced this issue Nov 17, 2019
I was not able to find an instance
where the cursor update was not immediate.

Fullscreen + Windowed seem to have the same
behaviour here.

Hence we ignore the flag D3DCURSOR_IMMEDIATE_UPDATE.

Fixes the mouse part of #306
Joshua-Ashton added a commit that referenced this issue Nov 20, 2019
I was not able to find an instance
where the cursor update was not immediate.

Fullscreen + Windowed seem to have the same
behaviour here.

Hence we ignore the flag D3DCURSOR_IMMEDIATE_UPDATE.

Fixes the mouse part of #306
Joshua-Ashton added a commit that referenced this issue Nov 26, 2019
I was not able to find an instance
where the cursor update was not immediate.

Fullscreen + Windowed seem to have the same
behaviour here.

Hence we ignore the flag D3DCURSOR_IMMEDIATE_UPDATE.

Fixes the mouse part of #306
Joshua-Ashton added a commit that referenced this issue Nov 27, 2019
I was not able to find an instance
where the cursor update was not immediate.

Fullscreen + Windowed seem to have the same
behaviour here.

Hence we ignore the flag D3DCURSOR_IMMEDIATE_UPDATE.

Fixes the mouse part of #306
Joshua-Ashton added a commit that referenced this issue Dec 6, 2019
I was not able to find an instance
where the cursor update was not immediate.

Fullscreen + Windowed seem to have the same
behaviour here.

Hence we ignore the flag D3DCURSOR_IMMEDIATE_UPDATE.

Fixes the mouse part of #306
Joshua-Ashton added a commit that referenced this issue Dec 13, 2019
I was not able to find an instance
where the cursor update was not immediate.

Fullscreen + Windowed seem to have the same
behaviour here.

Hence we ignore the flag D3DCURSOR_IMMEDIATE_UPDATE.

Fixes the mouse part of #306
Joshua-Ashton added a commit that referenced this issue Dec 16, 2019
I was not able to find an instance
where the cursor update was not immediate.

Fullscreen + Windowed seem to have the same
behaviour here.

Hence we ignore the flag D3DCURSOR_IMMEDIATE_UPDATE.

Fixes the mouse part of #306
Joshua-Ashton added a commit that referenced this issue Dec 16, 2019
I was not able to find an instance
where the cursor update was not immediate.

Fullscreen + Windowed seem to have the same
behaviour here.

Hence we ignore the flag D3DCURSOR_IMMEDIATE_UPDATE.

Fixes the mouse part of #306
@cynicer
Copy link
Author

cynicer commented Dec 30, 2019

Are these tickets still being worked on? Or should we reopen them in DXVK?

@Joshua-Ashton
Copy link
Owner

Its fine here

Joshua-Ashton added a commit to doitsujin/dxvk that referenced this issue Jan 18, 2020
@Joshua-Ashton
Copy link
Owner

Hi, this should be fixed in master

builds: https://git.froggi.es/doitsujin/dxvk/-/jobs

@cynicer
Copy link
Author

cynicer commented Jan 18, 2020

Sky looks good now, water reflections still don't work correctly (they appear completely flat, originally they had ripples). Also the minimap does not render correctly anymore (top right in the screenshot), this used to work already.

grafik

@cynicer cynicer changed the title FHX (Ferentus, Herrcot, Xiones): Sky and reflections not rendered FHX (Ferentus, Herrcot, Xiones) Issues Jan 18, 2020
@cynicer
Copy link
Author

cynicer commented Jan 21, 2020

I narrowed the minimap rendering issue (see screenshot in post above: transparent and not round). It's caused by commit 312905e8a34485dfb88e2c764d0d7bfaab47de04.

So the open issues atm for us are:

  • Minimap is rendered incorrectly (after 312905e8a34485dfb88e2c764d0d7bfaab47de04)
  • Water reflections are missing -> completely flat

Joshua-Ashton added a commit to doitsujin/dxvk that referenced this issue Jan 23, 2020
@cynicer
Copy link
Author

cynicer commented Jan 23, 2020

Confirming minimap works again after 792c74e, thanks!

@Joshua-Ashton
Copy link
Owner

Reflection stuff should be fixed as of doitsujin/dxvk@310ab6d

@cynicer
Copy link
Author

cynicer commented Feb 9, 2020

Seems to be working fine, thank you very much for your effort!
All major things are working now for us, I got some minor things, but I will test and document them in a new issue in DXVK :-)

@cynicer cynicer closed this as completed Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants