Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search/social images and other meta #11

Closed
JoshuaKGoldberg opened this issue Aug 22, 2022 · 1 comment · Fixed by #12
Closed

Add search/social images and other meta #11

JoshuaKGoldberg opened this issue Aug 22, 2022 · 1 comment · Fixed by #12
Assignees
@JoshuaKGoldberg
Labels
accepting prs enhancement New feature or request
Milestone
ChooseYourFramewo...

Comments

@JoshuaKGoldberg
Copy link
Owner

Meta tags and the like for OpenGraph, Twitter, and friends. It should be that when you share https://chooseyouframework.dev, there's a nice preview (https://cards-dev.twitter.com/validator).
@JoshuaKGoldberg JoshuaKGoldberg added enhancement New feature or request accepting prs labels Aug 22, 2022
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Aug 22, 2022
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 22, 2022
Merged
2 tasks
JoshuaKGoldberg added a commit that referenced this issue Aug 22, 2022
@JoshuaKGoldberg
feat: add social media previews (#12)
85cf1f1 
Overview
Adds a bunch of meta tags for OpenGraph and Twitter, as well as a preview.png image used as the preview.
PR Checklist

 Fixes #11
 I have run this code to verify it works
[ ] This PR includes unit tests for the code change
@JoshuaKGoldberg
Copy link
Owner Author

So apparently the card validator link just doesn't work anymore? and it's mostly not documented?? Docs fail. https://twittercommunity.com/t/card-error-unable-to-render-or-no-image-read-this-first/62736

Screenshot of the Twitter preview showing image, url, title, and description

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 22, 2022
Merged
2 tasks
JoshuaKGoldberg added a commit that referenced this issue Aug 22, 2022
@JoshuaKGoldberg
feat: use preview image during game load (#13)
1a8b8e9 
Overview
Uses :empty to set up the preview.png added in #11 as the game element's background image.
PR Checklist

 Fixes #3
 I have run this code to verify it works
[ ] This PR includes unit tests for the code change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
accepting prs enhancement New feature or request
Projects
None yet
Milestone
ChooseYourFramework Release
Development

Successfully merging a pull request may close this issue.

feat: add social media previews JoshuaKGoldberg/ChooseYourFramework
1 participant
@JoshuaKGoldberg