Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: build:release artifacts should always be committed to the main branch #170

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 4, 2024 · 3 comments
Closed
3 tasks done

🛠 Tooling: build:release artifacts should always be committed to the main branch #170

JoshuaKGoldberg opened this issue Jan 4, 2024 · 3 comments
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

This action's main branch hasn't updated its dist/ directory in 7 months. That means the published action doesn't include updates made to source files or packages... including #137.

#137 not being published is the root cause of JoshuaKGoldberg/all-contributors-for-repository#199.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :( labels Jan 4, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 4, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 4, 2024
Merged
3 tasks
@JoshuaKGoldberg
Copy link
Owner Author

Fixed by #171.

This was referenced Jan 4, 2024
Closed
Closed
@JoshuaKGoldberg
Copy link
Owner Author

JoshuaKGoldberg commented Jan 4, 2024 •
edited
Loading

fyi @johnnyreilly, this might be of interest to you... I'm not sold that this is the right solution.

@johnnyreilly
Copy link
Sponsor

Running in the precommit hook you mean? I do that - prompted by @jakebailey

I also have this workflow that checks dist is up to date

https://github.com/johnnyreilly/schemar/blob/main/.github/workflows/check-dist.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnnyreilly @JoshuaKGoldberg