Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in a11y bot creation #1003

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

DerTimonius
Copy link
Contributor

PR Checklist

Overview

This PR fixes an error associated with the newly implemented accessibility-alt-text-bot which was introduced by writing issue instead of issues.
I also looked into the GH actions docs and noticed that created is not a possible option on issues and pull requests - replaced with opened.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1003 (aa491b7) into main (20afaf4) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1003   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files          93       93           
  Lines        4992     4992           
  Branches      420      420           
=======================================
  Hits         4675     4675           
  Misses        316      316           
  Partials        1        1           
Flag Coverage Δ
create 70.87% <100.00%> (ø)
initialize 38.34% <33.33%> (ø)
migrate 69.76% <100.00%> (ø)
unit 68.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/writing/creation/dotGitHub/createWorkflowFile.ts 100.00% <100.00%> (ø)
...teps/writing/creation/dotGitHub/createWorkflows.ts 99.14% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done this kind of typo so many times 😄 thanks for the quick followup!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 8918987 into JoshuaKGoldberg:main Oct 31, 2023
17 checks passed
Copy link

🎉 This is included in version v1.42.1 🎉

The release is available on:

Cheers! 📦🚀

@DerTimonius
Copy link
Contributor Author

anytime, happy to help 🙂

@DerTimonius DerTimonius deleted the fix/a11y-bot-bug branch October 31, 2023 14:18
@JoshuaKGoldberg
Copy link
Owner

(intentionally no alt text on this image to test the bot: spongebob and patrick high fiving)

Copy link

Uh oh! @JoshuaKGoldberg, the image you shared is missing helpful alt text. Check #1003 (comment).

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@JoshuaKGoldberg
Copy link
Owner

Plankton holding a rolled up paper, happily saying 'at last my moment of triumph'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Accessibility alt text bot action is failing
2 participants