Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Bug: Accessibility alt text bot action is failing #999

Closed
3 tasks done
JoshuaKGoldberg opened this issue Oct 30, 2023 · 3 comments 路 Fixed by #1003
Closed
3 tasks done

馃悰 Bug: Accessibility alt text bot action is failing #999

JoshuaKGoldberg opened this issue Oct 30, 2023 · 3 comments 路 Fixed by #1003
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

The added action from #989 should be able to run.

Actual

https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/6697748677/workflow

Check failure on line 1 in .github/workflows/accessibility-alt-text-bot.yml

GitHub Actions / .github/workflows/accessibility-alt-text-bot.yml
Invalid workflow file
`issue` is not a valid event name

Additional Info

cc @DerTimonius - maybe introduced during PR review? Is this something you've seen before?
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Oct 30, 2023
@DerTimonius
Copy link
Contributor

Hm.. I'm guessing the if is the problem. I will create a quick repo to test if it's really necessary and then fix the bug later today!

@DerTimonius
Copy link
Contributor

The bug is a result of a typo... My bad...

@DerTimonius DerTimonius mentioned this issue Oct 31, 2023
Merged
3 tasks
JoshuaKGoldberg pushed a commit that referenced this issue Oct 31, 2023
@DerTimonius
fix: typo in a11y bot creation (#1003)
8918987 
<!-- 馃憢 Hi, thanks for sending a PR to create-typescript-app! 馃挅.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [X] Addresses an existing open issue: fixes #999 
- [X] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [X] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

This PR fixes an error associated with the newly implemented
`accessibility-alt-text-bot` which was introduced by writing `issue`
instead of `issues`.
I also looked into the GH actions docs and noticed that `created` is not
a possible option on issues and pull requests - replaced with `opened`.
@github-actions GitHub Actions
Copy link

馃帀 This is included in version v1.42.1 馃帀

The release is available on:

Cheers! 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: typo in a11y bot creation DerTimonius/create-typescript-app
2 participants
@JoshuaKGoldberg @DerTimonius