Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: .vscode/settings.json should set source.fixAll.eslint to "explicit", not true #1105

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 21, 2023 · 1 comment · Fixed by #1110
Closed
3 tasks done

🐛 Bug: .vscode/settings.json should set source.fixAll.eslint to "explicit", not true #1105

JoshuaKGoldberg opened this issue Dec 21, 2023 · 1 comment · Fixed by #1110
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Dec 21, 2023 •
edited

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

As of https://code.visualstudio.com/updates/v1_83#_code-actions-on-save-and-auto-save the auto-fixed-to value for "source.fixAll.eslint" is now "explicit" instead of true:

{
	"editor.codeActionsOnSave": {
		"source.fixAll.eslint": "explicit"
	},
}

Actual

This repo hasn't been updated to reflect that:

create-typescript-app/src/steps/writing/creation/dotVSCode.ts

Lines 33 to 36 in e7198e6

"settings.json": await formatJson({
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true,
},

Accepting PRs to update this repo to the new "explicit" setting!

Additional Info

Note that you'll need to update any file that mentions source.fixAll.eslint. See .vscode/settings.json.
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! labels Dec 21, 2023
@PraveenShinde3 PraveenShinde3 mentioned this issue Dec 22, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Dec 24, 2023
@PraveenShinde3 @JoshuaKGoldberg
feat: Updated source.fixAll.eslint to explicit (#1110)
274ec71 
<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #1105 
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

<!-- Description of what is changed and how the code change does that.
-->

Updated source.fixAll.eslint to "explicit"


![image](https://github.com/JoshuaKGoldberg/create-typescript-app/assets/107350270/08c05bfa-33db-4014-b32e-486c8a97fed8)

---------

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.50.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Updated source.fixAll.eslint to explicit PraveenShinde3/create-typescript-app
1 participant
@JoshuaKGoldberg