Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Bug: Created npm package version badge in README.md uses wrong package name #1108

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 22, 2023 · 1 comment 路 Fixed by #1109
Closed
3 tasks done

馃悰 Bug: Created npm package version badge in README.md uses wrong package name #1108

JoshuaKGoldberg opened this issue Dec 22, 2023 · 1 comment 路 Fixed by #1109
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Running with --mode create should create a README.md whose contents -especially including badge images- all refer to the created repository.

Actual

In JoshuaKGoldberg/github-username-to-emails@ea4dd3e#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R16, we see that the npm package version badge refers to create-typescript-app instead of github-username-to-emails:

	<img alt="npm package version" src="https://img.shields.io/npm/v/create-typescript-app?color=21bb42" />

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Dec 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 22, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Dec 22, 2023
@JoshuaKGoldberg
fix: use repository name in README.md npm package badge (#1109)
728eb4b 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1108
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Replaces the hardcoded `create-typescript-app` name with
`options.repository`. Also adds non-blank strings to unit tests so the
snapshots will reflect this.
@github-actions GitHub Actions
Copy link

馃帀 This is included in version v1.49.4 馃帀

The release is available on:

Cheers! 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use repository name in README.md npm package badge JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg