Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalize whether build happens before lint/knip #1152

Merged
merged 4 commits into from
Dec 30, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 30, 2023

PR Checklist

Overview

Finally makes it so a pnpm build || exit 0 only happens if bin is specified. This is because:

  • n/no-missing-import will complain if the referenced .js file doesn't exist
  • The only way for that file to exist is to build
  • But, building failing -especially in migrating an existing repo- shouldn't prevent the rest of the commands from running

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (620b6b6) 94.28% compared to head (f7c0de8) 94.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
+ Coverage   94.28%   94.32%   +0.03%     
==========================================
  Files          97       99       +2     
  Lines        5637     5676      +39     
  Branches      458      462       +4     
==========================================
+ Hits         5315     5354      +39     
  Misses        321      321              
  Partials        1        1              
Flag Coverage Δ
create 70.26% <61.90%> (+<0.01%) ⬆️
initialize 42.32% <59.52%> (+0.16%) ⬆️
migrate 69.75% <61.90%> (+0.08%) ⬆️
unit 72.37% <52.38%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 01704e9 into main Dec 30, 2023
16 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the normalize-build-before-lint branch December 30, 2023 16:04
Copy link

🎉 This is included in version v1.51.2 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Repository might not need to pnpm build || true in lint-knip.yml
1 participant