馃洜 Tooling: Repository might not need to pnpm build || true in lint-knip.yml #1087
Closed
3 tasks done
Labels
area: tooling
Managing the repository's maintenance
status: accepting prs
Please, send a pull request to resolve this!
type: cleanup
Tech debt or other code/repository cleanups
Bug Report Checklist
main
branch of the repository.Overview
Thanks to #1048, we see now that this repository has two bits of tooling that are different between its 馃崕 actual files and 馃崒 code templates (see Additional Info below for explanation of the emojis):
pnpm build || true
beforelint:knip
:create-typescript-app/.github/workflows/lint-knip.yml
Lines 6 to 8 in d66379b
lint:knip
:create-typescript-app/src/steps/writing/creation/dotGitHub/createWorkflows.ts
Line 122 in d66379b
I'd added
pnpm build || true
inlint-knip.yml
back in #553. It might have been necessary then, but doesn't seem necessary now? If Irm -rf lib
locally then runpnpm lint:knip
, nothing fails.I think this should be a straightforward fix of removing the
pnpm build || true
. That might fail in PR though, so not marking asgood first issue
. Maybe,good second issue
would be more accurate? Welcoming PRs from anybody who's feeling confident and/or has already completed an issue! 馃檪Additional Info
This repository is two things:
For the most part, the repository's end-to-end test for
--mode migration
makes sure that the 馃崕 actual files and 馃崒 code templates stay the same. As in, if one changes, the other needs to have the same change as well. But per #546, there are some files that were missed in that test. We're only now able to verify that they're the same as of #1048. That PR is where this discrepancy was discovered.The text was updated successfully, but these errors were encountered: