Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: rimraf coverage directories in --mode migrate #1248

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Jan 16, 2024

PR Checklist

Overview

Cleans coverage* directories as a part of --mode migrate so that format and lint runs don't take forever going through them.

Also cleans the directories at the beginning of all three end-to-end test formats. Sometimes I run them locally and it's a pain to have forgotten to clear the coverage directories in that case.

Thanks to @NanderTGA for suggesting using rimraf for Windows support. I would have used the *nix-only rm -rf by myself. 😄

Co-authored-by: @NanderTGA

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cdbe271) 94.82% compared to head (7145041) 94.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1248      +/-   ##
==========================================
- Coverage   94.82%   94.81%   -0.01%     
==========================================
  Files         104      104              
  Lines        5815     5804      -11     
  Branches      491      492       +1     
==========================================
- Hits         5514     5503      -11     
  Misses        300      300              
  Partials        1        1              
Flag Coverage Δ
create 70.07% <64.00%> (+0.03%) ⬆️
initialize 42.26% <68.00%> (+0.01%) ⬆️
migrate 69.88% <84.00%> (+0.11%) ⬆️
unit 75.59% <72.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 6774141 into main Jan 16, 2024
19 of 20 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the rimraf-coverage-in-migrate branch January 16, 2024 20:39
@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @NanderTGA for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @NanderTGA! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

Copy link

🎉 This is included in version v1.54.0 🎉

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg pushed a commit that referenced this pull request Jan 16, 2024
Adds @NanderTGA as a contributor for code.

This was requested by JoshuaKGoldberg [in this
comment](#1248 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Migration script takes a long time on "cleaning up files"
1 participant