Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Migration script takes a long time on "cleaning up files" #1221

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 9, 2024 · 2 comments · Fixed by #1248
Closed
3 tasks done

🛠 Tooling: Migration script takes a long time on "cleaning up files" #1221

JoshuaKGoldberg opened this issue Jan 9, 2024 · 2 comments · Fixed by #1248
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance status: needs investigation Further research required...? type: cleanup Tech debt or other code/repository cleanups
Milestone
Simpler Snapshots

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Jan 9, 2024 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Similar to #1131 on the surface, but for generally running with --mode migrate & similar. I'm seeing very long "Cleaning up files..." times.

Running the four commands manually with time...

...is there a way to speed this stuff up?

Additional Info

Spinning out of #860.
@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups labels Jan 9, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 9, 2024
@JoshuaKGoldberg JoshuaKGoldberg added status: needs investigation Further research required...? and removed status: accepting prs Please, send a pull request to resolve this! labels Jan 9, 2024
@JoshuaKGoldberg JoshuaKGoldberg added this to the Simpler Snapshots milestone Jan 9, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 16, 2024
Merged
3 tasks
@JoshuaKGoldberg
Copy link
Owner Author

Interesting: I ran locally and over a minute was spent running through the coverage-create directory. Lots of that was spent in huge files in a coverage-create/tmp. Interesting!

JoshuaKGoldberg added a commit that referenced this issue Jan 16, 2024
@JoshuaKGoldberg
perf: rimraf coverage directories in --mode migrate (#1248)
6774141 
<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #1221
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Cleans `coverage*` directories as a part of `--mode migrate` so that
format and lint runs don't take forever going through them.

Also cleans the directories at the beginning of all three end-to-end
test formats. Sometimes I run them locally and it's a pain to have
forgotten to clear the coverage directories in that case.

Thanks to @NanderTGA for suggesting using `rimraf` for Windows support.
I would have used the *nix-only `rm -rf` by myself. 😄

Co-authored-by: @NanderTGA
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.54.0 🎉

The release is available on:

Cheers! 📦🚀

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 17, 2024
Open
3 tasks
@johnnyreilly johnnyreilly mentioned this issue Feb 5, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance status: needs investigation Further research required...? type: cleanup Tech debt or other code/repository cleanups
Projects
None yet
Milestone
Simpler Snapshots
Development

Successfully merging a pull request may close this issue.

perf: rimraf coverage directories in --mode migrate JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg