🐛 Bug: Setup script should also uninstall chalk #193
Labels
good first issue
Good for newcomers, please hop on!
status: accepting prs
Please, send a pull request to resolve this!
type: bug
Something isn't working :(
Bug Report Checklist
main
branch of the repository.Expected
Forking explanation from #174 (comment):
In more detail: this repo contains a
script/
folder that includes asetup.js
file. That file is meant to be run (pnpm run setup
) when someone forks the template. "Setup" here refers to assorted repo tasks such as renaming to their repo name, populating GitHub labels, etc.The setup script is also meant to remove the
setup/
directory, remove any references to setup scripts, and uninstall any package dependencies only used by the setup script. This is done at the end of the setup script.chalk
is a package only used by the setup script. So it should be uninstalled at the end of the setup script.Actual
chalk
is not uninstalled here:https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/80e0a788cd32ffcc050f2c1bffd2c91803b32e4b/script/setup.js#L266
Additional Info
Originally reported by @webpro in #174 (comment) (thanks!)
The text was updated successfully, but these errors were encountered: