Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Setup script should also uninstall chalk #193

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 19, 2023 · 0 comments · Fixed by #264
Closed
3 tasks done

🐛 Bug: Setup script should also uninstall chalk #193

JoshuaKGoldberg opened this issue Jan 19, 2023 · 0 comments · Fixed by #264
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Forking explanation from #174 (comment):

In more detail: this repo contains a script/ folder that includes a setup.js file. That file is meant to be run (pnpm run setup) when someone forks the template. "Setup" here refers to assorted repo tasks such as renaming to their repo name, populating GitHub labels, etc.

The setup script is also meant to remove the setup/ directory, remove any references to setup scripts, and uninstall any package dependencies only used by the setup script. This is done at the end of the setup script.

chalk is a package only used by the setup script. So it should be uninstalled at the end of the setup script.

Actual

chalk is not uninstalled here:

https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/80e0a788cd32ffcc050f2c1bffd2c91803b32e4b/script/setup.js#L266

Additional Info

Originally reported by @webpro in #174 (comment) (thanks!)

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant