Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Bug: Created repos default to incorrect merge commit messages #531

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jun 14, 2023 · 2 comments 路 Fixed by #532
Closed
3 tasks done

馃悰 Bug: Created repos default to incorrect merge commit messages #531

JoshuaKGoldberg opened this issue Jun 14, 2023 · 2 comments 路 Fixed by #532
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

This template relies on conventional commits for releasing:

Therefore, it's important that PR merge messages adhere to the PR title of the merged PR. Otherwise nothing will get released!

Actual

I created a new repo this week, https://github.com/JoshuaKGoldberg/prettier-plugin-curly, and its settings for PR just goes with the default merge commit title. Example from JoshuaKGoldberg/prettier-plugin-curly@d5486a8:

Merge pull request #12 from JoshuaKGoldberg/all-contributors/add-so1ve 

docs: add so1ve as a contributor for bug

We want to instead default to the PR title and description, per https://github.blog/changelog/2022-08-23-new-options-for-controlling-the-default-commit-message-when-merging-a-pull-request/.

docs: add so1ve as a contributor for bug

etc. etc.

Additional Info

https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#update-a-repository mentions how to do this in the GitHub API. If the API doesn't work, it should be documented as part of setup in the README that you should do this manually. But it looks like the API should be enough.
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Jun 14, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jun 14, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jun 14, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Jun 14, 2023
@JoshuaKGoldberg
fix: specify squash merge defaults in repo setup (#532)
d76f59d 
## PR Checklist

- [x] Addresses an existing open issue: fixes #531
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds the two settings for the GitHub API per
https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#update-a-repository.
@github-actions
Copy link

馃帀 This is included in version v1.28.16 馃帀

The release is available on:

Cheers! 馃摝馃殌

1 similar comment
@github-actions
Copy link

馃帀 This is included in version v1.28.16 馃帀

The release is available on:

Cheers! 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: specify squash merge defaults in repo setup JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg