-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃殌 Feature: Add a --privacy flag for publishConfig > access #665
Comments
@JoshuaKGoldberg I'm sorry, my explanation is lacking. My issue is
https://github.com/laststance/usd-query/actions/runs/5927145432/job/16070031891#step:9:50
https://github.com/laststance/usd-query/actions/runs/5927145432/job/16070031891#step:9:50 I passed --public, but --provenance option blocked publish because new package I atemmpt publish. My understand correctly, this teemplate couldn't ship new package without modify config tempolary. |
@JoshuaKGoldberg Recently, I've gotten used to npm publish and release-it, and I've come to think that this is not an issue at all. |
Sure, works for me! |
Ah, I actually hit this today:
I'll add this feature in after all. 馃槃 |
## PR Checklist - [x] Addresses an existing open issue: fixes #665 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Defaults to `--access public`, but provides an escape hatch for private packages.
馃帀 This is included in version v1.32.0 馃帀 The release is available on: Cheers! 馃摝馃殌 |
Bug Report Checklist
main
branch of the repository.Overview
Publish configs were added in #465 -> #466. It should be that if you initialize a new repository and add the requisite tokens, publishing should work immediately. But, per https://twitter.com/malloc007/status/1693623834509824120, the lack of
access: true
means packages might not immediately publish well.Let's add a
--privacy
flag that defaults to"public"
. That way users have control over whether the package is public or private, and it's surfaced in the docs.Additional Info
Thanks @ryota-murakami for speaking up! 鉂わ笍
The text was updated successfully, but these errors were encountered: