Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃殌 Feature: Skip "Cleaning up files" if options.skipInstall is true #706

Closed
3 tasks done
JoshuaKGoldberg opened this issue Aug 25, 2023 · 1 comment 路 Fixed by #975
Closed
3 tasks done

馃殌 Feature: Skip "Cleaning up files" if options.skipInstall is true #706

JoshuaKGoldberg opened this issue Aug 25, 2023 · 1 comment 路 Fixed by #975
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Right now, after someone runs npx template-typescript-node-package, the setup scripts will run a few commands to autofix / clean up files locally:

https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/a386c870f5bc53ce3b30a8d31108c5726487ba78/src/create/createWithOptions.ts#L35-L39

But those commands will generally fail if options.skipInstall is true (i.e. if the user specified --skip-install). For example, linting will likely fail because the required ESLint plugins' packages wouldn't likely be installed.

Let's not run those commands if options.skipInstall is true.

Additional Info

See also #705 for some context on those cleanup commands.
@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Aug 25, 2023
@GV14982 GV14982 mentioned this issue Oct 20, 2023
Merged
3 tasks
JoshuaKGoldberg pushed a commit that referenced this issue Oct 20, 2023
@GV14982
feat: skip file cleanup if installation is skipped (#975)
aef28f2 
<!-- 馃憢 Hi, thanks for sending a PR to create-typescript-app! 馃挅.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #706
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

<!-- Description of what is changed and how the code change does that.
-->

Moved the "Cleaning up files" `runCommand` call inside of the preceding
conditional to only run if packages were installed.

For some reason my terminal won't let me put in emojis, so I'll use
<(-.-)>
@github-actions
Copy link

馃帀 This is included in version v1.39.0 馃帀

The release is available on:

Cheers! 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: skip file cleanup if installation is skipped GV14982/create-typescript-app
1 participant
@JoshuaKGoldberg