Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Error in git commit on created repo: "The '.husky/pre-commit' hook was ignored because it's not set as executable." #718

Closed
3 tasks done
JoshuaKGoldberg opened this issue Aug 27, 2023 · 1 comment · Fixed by #719
Closed
3 tasks done

🐛 Bug: Error in git commit on created repo: "The '.husky/pre-commit' hook was ignored because it's not set as executable." #718

JoshuaKGoldberg opened this issue Aug 27, 2023 · 1 comment · Fixed by #719
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Milestone
Ready to Rename

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Aug 27, 2023 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Repos created with npx template-typescript-node-package should be able to commit with the Husky pre-commit hook.

Actual

$ git commit -m "example commit"
hint: The '.husky/pre-commit' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
[main c1b08d1] build: add missing access: public to package.json
 1 file changed, 1 insertion(+)

Additional Info

Spotted creating https://github.com/JoshuaKGoldberg/cached-factory.
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Aug 27, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Ready to Rename milestone Aug 27, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Aug 27, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 29, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Aug 29, 2023
@JoshuaKGoldberg
fix: chmod ug+x .husky/pre-commit after writing structure (#719)
9a8b98b 
## PR Checklist

- [x] Addresses an existing open issue: fixes #718
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Applies the suggested fix from
typicode/husky#1177 of manually changing the
file's mode with `chmod`.
@github-actions
Copy link

🎉 This is included in version v1.29.10 🎉

The release is available on:

Cheers! 📦🚀

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 6, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
Ready to Rename
Development

Successfully merging a pull request may close this issue.

fix: chmod ug+x .husky/pre-commit after writing structure JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg