Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Remove "Would you like to push the template's tooling up to the repository on GitHub?" #920

Closed
3 tasks done
JoshuaKGoldberg opened this issue Oct 1, 2023 · 1 comment · Fixed by #921 or #922
Closed
3 tasks done

🚀 Feature: Remove "Would you like to push the template's tooling up to the repository on GitHub?" #920

JoshuaKGoldberg opened this issue Oct 1, 2023 · 1 comment · Fixed by #921 or #922
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Milestone
Post-Rename Migra...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

...
│
◇  ✅ Passed creating repository structure.
│
◇  ✅ Passed adding contributors to table.
│
◇  ✅ Passed installing packages.
│
◇  ✅ Passed cleaning up files.
│
◆  Would you like to push the template's tooling up to the repository on GitHub?
│  ● Yes / ○ No
└

I'd added that ending "Would you like to push the template's tooling up to the repository on GitHub?" notice long ago, when the template was much less configurable. There's not really a need for it anymore. Let's get rid of it. 🔪

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Oct 1, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Oct 1, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Post-Rename Migration milestone Oct 1, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 1, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Oct 1, 2023
@JoshuaKGoldberg
feat: remove --create-repository option (#921)
dd69dd5 
## PR Checklist

- [x] Addresses an existing open issue: fixes #920
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Removes the option.
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 1, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Oct 1, 2023
@JoshuaKGoldberg
fix: correct create-repository-by-default logic (#922)
ef2e348 
## PR Checklist

- [x] Addresses an existing open issue: fixes #920 (but better)
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

I remember now why `--create-repository` existed: if `mode` is `create`,
then we'll want to attempt creating a new repo by default. So this PR
infers a `createRepository` again in `ensureRepositoryExists`.
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
Post-Rename Migration
1 participant
@JoshuaKGoldberg