Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: how to create a GitHub Action #1196

Merged
merged 35 commits into from
Jan 28, 2024
Merged

docs: how to create a GitHub Action #1196

merged 35 commits into from
Jan 28, 2024

Conversation

johnnyreilly
Copy link
Sponsor Collaborator

@johnnyreilly johnnyreilly commented Jan 6, 2024

PR Checklist

Overview

This PR provides docs on how to create a GitHub Action

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1080ec) 94.81% compared to head (4b6095e) 94.79%.
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1196      +/-   ##
==========================================
- Coverage   94.81%   94.79%   -0.03%     
==========================================
  Files         104      103       -1     
  Lines        5804     5781      -23     
  Branches      492      490       -2     
==========================================
- Hits         5503     5480      -23     
  Misses        300      300              
  Partials        1        1              
Flag Coverage Δ
create 69.93% <ø> (-0.15%) ⬇️
initialize 42.40% <ø> (+0.13%) ⬆️
migrate 69.83% <ø> (-0.06%) ⬇️
unit 75.66% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! I left a bunch of nits because that's who I am as a person 😄 but fundamentally I really like this guide. Thanks for getting it started!

docs/FAQs.md Outdated Show resolved Hide resolved
docs/FAQs.md Outdated Show resolved Hide resolved
docs/FAQs.md Outdated Show resolved Hide resolved
docs/FAQs.md Outdated Show resolved Hide resolved
docs/FAQs.md Outdated Show resolved Hide resolved
docs/FAQs.md Outdated Show resolved Hide resolved
docs/FAQs.md Outdated Show resolved Hide resolved
script/__snapshots__/migrate-test-e2e.js.snap Outdated Show resolved Hide resolved
docs/FAQs.md Outdated Show resolved Hide resolved
docs/FAQs.md Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Jan 6, 2024
johnnyreilly and others added 6 commits January 6, 2024 21:30
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
docs/FAQs.md Outdated Show resolved Hide resolved
@johnnyreilly
Copy link
Sponsor Collaborator Author

as predicted, my return to work has laid waste to my OSS time. I've done a few edits - where do things stand with this?

@johnnyreilly
Copy link
Sponsor Collaborator Author

gah now pnpm run build is failing with out of memory:

DTS Build start
node:events:495
      throw er; // Unhandled 'error' event
      ^

Error [ERR_WORKER_OUT_OF_MEMORY]: Worker terminated due to reaching memory limit: JS heap out of memory
    at new NodeError (node:internal/errors:405:5)
    at [kOnExit] (node:internal/worker:287:26)
    at Worker.<computed>.onexit (node:internal/worker:209:20)
Emitted 'error' event on Worker instance at:
    at [kOnExit] (node:internal/worker:287:12)
    at Worker.<computed>.onexit (node:internal/worker:209:20) {
  code: 'ERR_WORKER_OUT_OF_MEMORY'
}

Node.js v18.18.2
 ELIFECYCLE  Command failed with exit code 1.

@johnnyreilly
Copy link
Sponsor Collaborator Author

Fixed by export NODE_OPTIONS="--max-old-space-size=4096"

@johnnyreilly
Copy link
Sponsor Collaborator Author

Okay I'm baffled now. I haven't changed anything, but I'm now seeing this failure in the tests:

/home/runner/work/create-typescript-app/create-typescript-app/create-typescript-app/knip.jsonc
Error:   5:29  error  Unexpected trailing comma  jsonc/comma-dangle

I haven't changed anything - why would the tests be failing?!

johnnyreilly and others added 4 commits January 16, 2024 21:00
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@JoshuaKGoldberg
Copy link
Owner

I haven't changed anything - why would the tests be failing?!

Yeah sorry, that was a break on main. I fixed it.

@github-actions github-actions bot removed the status: waiting for author Needs an action taken by the original poster label Jan 24, 2024
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is really close to merge, thanks! Just a few small touchups. I could make them myself but want to get your input. 🙂

docs/FAQs.md Outdated Show resolved Hide resolved
docs/FAQs.md Outdated Show resolved Hide resolved
docs/FAQs.md Outdated Show resolved Hide resolved
docs/FAQs.md Outdated
Comment on lines 131 to 136
4. Our GitHub Action needs Node.js 20 so we'll update `.github/actions/prepare/action.yml`:

```diff
-node-version: "18"
+node-version: "20"
```
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/FAQs.md Outdated Show resolved Hide resolved
docs/FAQs.md Outdated Show resolved Hide resolved
docs/FAQs.md Outdated Show resolved Hide resolved
johnnyreilly and others added 5 commits January 24, 2024 20:13
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@johnnyreilly
Copy link
Sponsor Collaborator Author

Yo @JoshuaKGoldberg! I'm back home! I think I've now looked at all the feedback - not sure though; still not quite trusting GitHub to surface stuff. Are we there?

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is looking great, thank you so much (as always) @johnnyreilly for dealing with my pickiness and GitHub shenanigans!

Let's get this merged 🚀

docs/FAQs.md Outdated Show resolved Hide resolved
@JoshuaKGoldberg
Copy link
Owner

Test failures are unrelated. Sigh.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 1e99b68 into main Jan 28, 2024
11 of 13 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the docs-github-action branch January 28, 2024 07:15
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @johnnyreilly for doc.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @johnnyreilly! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

JoshuaKGoldberg pushed a commit that referenced this pull request Jan 28, 2024
Adds @johnnyreilly as a contributor for doc.

This was requested by JoshuaKGoldberg [in this
comment](#1196 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Copy link

🎉 This is included in version v1.57.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 Documentation: Mention how to set up a GitHub Action
2 participants