Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: do not run accessibility checks for bots #1319

Merged
merged 5 commits into from
Feb 18, 2024

Conversation

danvk
Copy link
Contributor

@danvk danvk commented Feb 18, 2024

PR Checklist

Overview

See linked issue. I set this up in my repo in danvk/gravlax#58 following typescript-eslint/typescript-eslint#8212. We can wait for a few renovate bot updates on my repo to confirm that this has the desired effect.

I added support for top-level if statements on jobs. It's possible to skip an individual step (which is already supported) but skipping the entire job seems more correct: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idif

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9144884) 95.89% compared to head (aa2830c) 95.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1319   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files         104      104           
  Lines        5796     5799    +3     
  Branches      499      500    +1     
=======================================
+ Hits         5558     5561    +3     
  Misses        237      237           
  Partials        1        1           
Flag Coverage Δ
create 69.90% <100.00%> (+0.01%) ⬆️
initialize 42.55% <33.33%> (-0.01%) ⬇️
migrate 69.82% <100.00%> (+0.01%) ⬆️
unit 76.93% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnnyreilly
Copy link
Sponsor Collaborator

Wait what... You mean you don't get joy from the accessibility bot fighting the dependency bot?! 🤖🪖

Copy link
Sponsor Collaborator

@johnnyreilly johnnyreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve but I'll hold fire for @JoshuaKGoldberg

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks!

Agreed on the skipping the whole job, +1.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 218df8f into JoshuaKGoldberg:main Feb 18, 2024
17 checks passed
@JoshuaKGoldberg
Copy link
Owner

Wait what... You mean you don't get joy from the accessibility bot fighting the dependency bot?! 🤖🪖

Honestly this cracks me up every time. I might leave this disabled for one or two personal smaller repos just as a test to see if any bots get into fights again. 😂

@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @danvk for infra.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

We had trouble processing your request. Please try again later.

@johnnyreilly
Copy link
Sponsor Collaborator

We had trouble processing your request. Please try again later.

Oh the irony

@JoshuaKGoldberg
Copy link
Owner

lol. if it's not that, it's all-contributors/app#468 ...

Copy link

🎉 This is included in version v1.57.9 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Don't run compliance/accessibility checks on renovate PRs
3 participants